feat: validate mustache variable in workflow YAML #4485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XL
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces structured mustache variable validation in workflow YAML, updating error types and enhancing error handling and UI feedback throughout the workflow editor and store.
- Refactored mustache validation logic in /keep-ui/entities/workflows/lib/validation.ts, including fixing a template literal interpolation issue.
- Updated error and type definitions in /keep-ui/entities/workflows/model/types.ts and integrated structured errors.
- Modified workflow store in /keep-ui/entities/workflows/model/workflow-store.ts to filter and process tuple-based validation errors.
- Enhanced node error display in /keep-ui/features/workflows/builder/ui/WorkflowNode.tsx with dynamic styling.
- Added the useYamlValidation hook and supporting toolbar in /keep-ui/shared/ui/WorkflowYAMLEditor/lib/useYamlValidation.ts and ...Toolbar.tsx.
13 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
keep-ui/shared/ui/WorkflowYAMLEditor/ui/WorkflowYAMLValidationErrors.tsx
Show resolved
Hide resolved
dosubot
bot
added
size:XXL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4478