Skip to content

fix: [Alert enrichment] when changing status of incident, other enrichments of alerts are gone #5259 #5260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: [Alert enrichment] when changing status of incident, other enrichments of alerts are gone #5259 #5260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
992b23b
fixes #5259
bbcorp Aug 18, 2025
f8b27b8
version
bbcorp Aug 19, 2025
5ad264d
0.47.2
bbcorp Aug 20, 2025
9ecbd81
merge
bbcorp Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions keep/api/core/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,15 +1395,20 @@ def batch_enrich(
}

# Prepare bulk update for existing enrichments
to_update = []
to_create = []
audit_entries = []

for fingerprint in fingerprints:
existing = existing_enrichments.get(fingerprint)

if existing:
to_update.append(existing.id)
# AlertEnrichment exist, update and merge enrichments
new_enrichment_data = {**existing.enrichments, **enrichments}
stmt = (
update(AlertEnrichment)
.where(AlertEnrichment.id == existing.id)
.values(enrichments=new_enrichment_data)
)
session.execute(stmt)
else:
# For new entries
to_create.append(
Expand All @@ -1425,15 +1430,6 @@ def batch_enrich(
)
)

# Bulk update in a single query
if to_update:
stmt = (
update(AlertEnrichment)
.where(AlertEnrichment.id.in_(to_update))
.values(enrichments=enrichments)
)
session.execute(stmt)

# Bulk insert new enrichments
if to_create:
session.add_all(to_create)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "keep"
version = "0.47.1"
version = "0.47.2"
description = "Alerting. for developers, by developers."
authors = ["Keep Alerting LTD"]
packages = [{include = "keep"}]
Expand Down
Loading