Skip to content

allow # in IDs #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2018
Merged

allow # in IDs #59

merged 2 commits into from
Jul 30, 2018

Conversation

snopoke
Copy link
Collaborator

@snopoke snopoke commented Jul 27, 2018

No description provided.

@snopoke
Copy link
Collaborator Author

snopoke commented Jul 30, 2018

@kennknowles

@kennknowles
Copy link
Owner

Seems harmless enough. Not technically in any other JSONPath that I know of, and you can always quote in order to put whatever characters you want.

@kennknowles kennknowles merged commit 2ceae10 into kennknowles:master Jul 30, 2018
@snopoke snopoke deleted the lex_hash branch July 30, 2018 16:24
@snopoke
Copy link
Collaborator Author

snopoke commented Jul 30, 2018

@kennknowles interesting, I didn't know about the quoting though I see now that it's in the docs. I'd rather revert this then and just go with that approach

@snopoke snopoke mentioned this pull request Jul 30, 2018
@snopoke
Copy link
Collaborator Author

snopoke commented Jul 30, 2018

Reverted here: #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants