Additions: add clear button in core + add selected item support #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liorheber
reviewed
Jan 8, 2021
liorheber
reviewed
Jan 8, 2021
liorheber
reviewed
Jan 8, 2021
packages/core/src/input/input.js
Outdated
| @@ -22,6 +24,11 @@ const Input = props => { | |||
| value={searchTerm} | |||
| onChange={onInputChange} | |||
| /> | |||
| {searchTerm !== "" && ( | |||
| <span css={getStyles("clearInput", props)} onClick={onInputChange}> | |||
There was a problem hiding this comment.
I think this should be a button element, not a span.
It's intended for a click.
liorheber
reviewed
Jan 8, 2021
liorheber
reviewed
Jan 8, 2021
liorheber
reviewed
Jan 8, 2021
packages/core/src/item/item.js
Outdated
| @@ -6,6 +6,7 @@ import SearchedItem from "./searched_item/searched_item"; | |||
| import BasicItem from "./basic_item"; | |||
|
|
|||
| export const ForwardIconRenderer = () => <>➡️</>; | |||
| const defaultSelectedItem = { item: [], leaf: "" }; | |||
There was a problem hiding this comment.
Shouldn't the default be undefined? Nothing selected.
There was a problem hiding this comment.
Even when nothing is selected I check if selectedItem equals to the current item that renders.
I'm using toString to check if the arrays are equal so I need to give a default that is different them undefined
liatgo
force-pushed
the
add-clear-button-and-mark-selected-item
branch
from
d5ef1c0 to
9674229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO - update README about selectedItem and remove markSelectedItem
1. Add clear button to core input:
2. Mark selected item (core + material):
basic mode:
search mode:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: