Skip to content

Fix monorepo setup #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2020
Merged

Fix monorepo setup #25

merged 5 commits into from
Feb 24, 2020

Conversation

hipstersmoothie
Copy link
Contributor

@hipstersmoothie hipstersmoothie commented Feb 24, 2020

  • Auto only works at root => move release script to root
  • Add lerna to manage monorepo version + add initial setup
  • mark docs package as private so lerna doesn't publish it

In relation to: intuit/auto#988

@hipstersmoothie
Copy link
Contributor Author

hipstersmoothie commented Feb 24, 2020

This build is failing probably because Travis isn't sharing secrets with untrusted forks.

Travis CI makes encrypted variables and data available only to pull requests coming from the same repository. These are considered trustworthy, as only members with write access to the repository can send them.

Pull requests sent from forked repositories do not have access to encrypted variables or data even if these are defined in the fork source project.

https://docs.travis-ci.com/user/pull-requests/

You might want to check if the NPM_TOKEN exists before running release so builds from forks don't always fail.

EDIT: ^^ I did this in your config 👍

@hipstersmoothie
Copy link
Contributor Author

This is now failing because of other environment variable but should be good from auto's side

@liorheber
Copy link
Contributor

Yes, I see. Thanks a lot!
Really impressed with Auto by the way. I hope we migrate our internal projects to use it as well.

@liorheber liorheber merged commit 0846c18 into kenshoo:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants