fix get_lora_target_names function #2167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keras_hub/src/models/backbone.py
Outdated
| @@ -202,7 +204,7 @@ def enable_lora(self, rank, target_names=None): | |||
| of the attention layers. | |||
| """ | |||
| if target_names is None: | |||
| target_names = self.get_lora_target_names() | |||
| target_names = self.get_lora_target_names(target_names=None) | |||
There was a problem hiding this comment.
get_lora_target_names() won't still work correctly in the following code and will return the default values:
model.enable_lora(rank=2, target_names=["query"])
model.get_lora_target_names()
I don't think we should expect the user to pass the target names to get the target names. If they already know what the target names are, they won't have to call get_lora_target_names().
Maybe it'd be good to define a new member variable like lora_target_names and define setter/getter for it and initialize it with default values.
mattdangerw
reviewed
Apr 1, 2025
|
@divyashreepathihalli are you still working on this? |
|
This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.