-
Notifications
You must be signed in to change notification settings - Fork 296
Move Bert to models folder #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some comments. Just focusing on the high level for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a more detailed pass of comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments.
Axes we should test this on (though need not be all on this PR):
This PR has an example of how to test with and without jit_compile (with XLA and without XLA) in a parameterized test. We can figure out weight loading tests, and what (if any) correctness testing we want to do in unit testing after we actually have some checkpoints to load. |
I added a docstring example usage for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, last few comments on this round of the API I think!
@jbischof re docstrings. The Anyway, most of the testing should be on the unit tests. That's just a good way to make sure our docstring don't get stale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another couple spots I just noticed!
Of these, I think 1. and 4. are probably the ones we should make sure to have on this PR. @chenmoneygithub are you OK to review the testing code on this when it is ready (probably quite shortly)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from me! With the understanding that testing will come in here after I'm on vacay.
Thanks for the huge amount of work here. This is big!!
Following the general design pattern of
keras-cv
.Bert
first model inmodels/
folderBertBase
configured in codeBertClassifier
APITest plan: unit tests + ran
examples/bert/*
by hand.