Skip to content

Add GELU to activations.py VERSION 2 #11839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add GELU to activations.py VERSION 2 #11839

wants to merge 1 commit into from

Conversation

SriRangaTarun
Copy link
Contributor

Summary

Add GELU activation functions. Here are the fast and slow implementations.

Related Issues

This issue

PR Overview

Adds two GELU implementations : one fast and one slow to activations.py.

  • [n] This PR requires new unit tests [y/n] (make sure tests are included)
  • [y] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • [y] This PR is backwards compatible [y/n]
  • [n] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

@Dref360
Copy link
Contributor

Dref360 commented Dec 10, 2018

I don't think this should be merged into Keras.

Not widely used
Not published yet
Please submit your PR at keras-contrib.

@gabrieldemarmiesse
Copy link
Contributor

Well I agree. This is something that users can easily do themselves (it's a one liner) and even if this is used a lot, the layer should pass the test of time to be integrated in core keras. If users don't use it anymore in six months, that's not worth it.

Let's wait for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants