Skip to content

[keras/mixed_precision] Standardise docstring usage of "Default to" #17973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SamuelMarks
Copy link
Contributor

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748

@gbaned gbaned requested a review from haifeng-jin April 13, 2023 05:56
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Apr 13, 2023
Copy link
Contributor

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No more comments from me.

@haifeng-jin haifeng-jin removed the keras-team-review-pending Pending review by a Keras team member. label Apr 21, 2023
@gbaned gbaned requested a review from haifeng-jin May 4, 2023 08:17
@gbaned gbaned added the keras-team-review-pending Pending review by a Keras team member. label May 4, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 4, 2023
copybara-service bot pushed a commit that referenced this pull request May 5, 2023
…fault to"

Imported from GitHub PR #17973

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
b43b215 by Samuel Marks <[email protected]>:

[keras/mixed_precision/loss_scale_optimizer.py] Standardise docstring usage of "Default to"

--
19dcdeb by Samuel Marks <[email protected]>:

[keras/mixed_precision/loss_scale_optimizer.py] Docstring minor improvements

Merging this change closes #17973

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17973 from SamuelMarks:keras.mixed_precision-defaults-to 19dcdeb
PiperOrigin-RevId: 529706785
@divyashreepathihalli divyashreepathihalli removed the keras-team-review-pending Pending review by a Keras team member. label May 5, 2023
@copybara-service copybara-service bot merged commit 8261e7f into keras-team:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Ready to be merged into the codebase size:S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants