Skip to content

Fix failing CI on coverage testing #20398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

nicolaspi
Copy link
Contributor

Fixes #20397
Reference nedbat/coveragepy#512

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (1efa171) to head (c0494c7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20398      +/-   ##
==========================================
+ Coverage   76.58%   82.38%   +5.80%     
==========================================
  Files         502      502              
  Lines       46367    46415      +48     
  Branches     7340     7332       -8     
==========================================
+ Hits        35509    38240    +2731     
+ Misses       9131     6394    -2737     
- Partials     1727     1781      +54     
Flag Coverage Δ
keras 82.24% <ø> (+5.73%) ⬆️
keras-jax 64.98% <ø> (+0.07%) ⬆️
keras-numpy 59.83% <ø> (+0.05%) ⬆️
keras-tensorflow 66.09% <ø> (+0.01%) ⬆️
keras-torch 64.94% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolaspi nicolaspi changed the title Fix failing CI for coverage testing Fix failing CI on coverage testing Oct 23, 2024
Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Oct 23, 2024
@fchollet fchollet merged commit 49a3063 into keras-team:master Oct 23, 2024
8 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to reenable coverage test on CI
4 participants