Fixed issue with dot_product_attention when using TPU. #21254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21254 +/- ##
==========================================
- Coverage 82.59% 82.53% -0.07%
==========================================
Files 564 564
Lines 54594 54642 +48
Branches 8483 8495 +12
==========================================
+ Hits 45092 45098 +6
- Misses 7415 7454 +39
- Partials 2087 2090 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
fchollet
reviewed
May 7, 2025
keras/src/backend/jax/nn.py
Outdated
| strides: a sequence of `N` integers, representing the inter-window | ||
| strides (default: `(1, ..., 1)`). | ||
| strides (default: `(1, ..., 1)`). |
keras/src/backend/jax/nn.py
Outdated
| "Sharding along sequence dimension not allowed in tpu kernel " | ||
| "attention" | ||
| "Sharding along sequence dimension not allowed" | ||
| " in tpu kernel attention" |
keras/src/backend/jax/nn.py
Outdated
|
|
||
| Args: | ||
| query: Queries with shape `[batch, time, heads, | ||
| depth_k]`. |
There was a problem hiding this comment.
Please use 4-space indent
Corrected indentation in doc string
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
awaiting review
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.