Skip to content

Commit 04cb1db

Browse files
puranjaymohanKernel Patches Daemon
authored and
Kernel Patches Daemon
committed
bbpf: usdt arm arg parsing support
Parsing of USDT arguments is architecture-specific; on arm it is relatively easy since registers used are r[0-10], fp, ip, sp, lr, pc. Format is slightly different compared to aarch64; forms are - "size @ [ reg, #offset ]" for dereferences, for example "-8 @ [ sp, #76 ]" ; " -4 @ [ sp ]" - "size @ reg" for register values; for example "-4@r0" - "size @ #value" for raw values; for example "-8@#1" Add support for parsing USDT arguments for ARM architecture. Signed-off-by: Puranjay Mohan <[email protected]>
1 parent c645412 commit 04cb1db

File tree

1 file changed

+82
-0
lines changed

1 file changed

+82
-0
lines changed

tools/lib/bpf/usdt.c

Lines changed: 82 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1505,6 +1505,88 @@ static int parse_usdt_arg(const char *arg_str, int arg_num, struct usdt_arg_spec
15051505
return len;
15061506
}
15071507

1508+
#elif defined(__arm__)
1509+
1510+
static int calc_pt_regs_off(const char *reg_name)
1511+
{
1512+
int reg_num;
1513+
1514+
if (sscanf(reg_name, "r%d", &reg_num) == 1) {
1515+
if (reg_num >= 0 && reg_num <= 10)
1516+
return offsetof(struct pt_regs, uregs[reg_num]);
1517+
} else if (strcmp(reg_name, "fp") == 0) {
1518+
return offsetof(struct pt_regs, ARM_fp);
1519+
} else if (strcmp(reg_name, "ip") == 0) {
1520+
return offsetof(struct pt_regs, ARM_ip);
1521+
} else if (strcmp(reg_name, "sp") == 0) {
1522+
return offsetof(struct pt_regs, ARM_sp);
1523+
} else if (strcmp(reg_name, "lr") == 0) {
1524+
return offsetof(struct pt_regs, ARM_lr);
1525+
} else if (strcmp(reg_name, "pc") == 0) {
1526+
return offsetof(struct pt_regs, ARM_pc);
1527+
}
1528+
pr_warn("usdt: unrecognized register '%s'\n", reg_name);
1529+
return -ENOENT;
1530+
}
1531+
1532+
static int parse_usdt_arg(const char *arg_str, int arg_num, struct usdt_arg_spec *arg)
1533+
{
1534+
char reg_name[16];
1535+
int arg_sz, len, reg_off;
1536+
long off;
1537+
1538+
if (sscanf(arg_str, " %d @ \[ %15[a-z0-9], #%ld ] %n", &arg_sz, reg_name,
1539+
&off, &len) == 3) {
1540+
/* Memory dereference case, e.g., -4@[fp, #96] */
1541+
arg->arg_type = USDT_ARG_REG_DEREF;
1542+
arg->val_off = off;
1543+
reg_off = calc_pt_regs_off(reg_name);
1544+
if (reg_off < 0)
1545+
return reg_off;
1546+
arg->reg_off = reg_off;
1547+
} else if (sscanf(arg_str, " %d @ \[ %15[a-z0-9] ] %n", &arg_sz, reg_name, &len) == 2) {
1548+
/* Memory dereference case, e.g., -4@[sp] */
1549+
arg->arg_type = USDT_ARG_REG_DEREF;
1550+
arg->val_off = 0;
1551+
reg_off = calc_pt_regs_off(reg_name);
1552+
if (reg_off < 0)
1553+
return reg_off;
1554+
arg->reg_off = reg_off;
1555+
} else if (sscanf(arg_str, " %d @ #%ld %n", &arg_sz, &off, &len) == 2) {
1556+
/* Constant value case, e.g., 4@#5 */
1557+
arg->arg_type = USDT_ARG_CONST;
1558+
arg->val_off = off;
1559+
arg->reg_off = 0;
1560+
} else if (sscanf(arg_str, " %d @ %15[a-z0-9] %n", &arg_sz, reg_name, &len) == 2) {
1561+
/* Register read case, e.g., -8@r4 */
1562+
arg->arg_type = USDT_ARG_REG;
1563+
arg->val_off = 0;
1564+
reg_off = calc_pt_regs_off(reg_name);
1565+
if (reg_off < 0)
1566+
return reg_off;
1567+
arg->reg_off = reg_off;
1568+
} else {
1569+
pr_warn("usdt: unrecognized arg #%d spec '%s'\n", arg_num, arg_str);
1570+
return -EINVAL;
1571+
}
1572+
1573+
arg->arg_signed = arg_sz < 0;
1574+
if (arg_sz < 0)
1575+
arg_sz = -arg_sz;
1576+
1577+
switch (arg_sz) {
1578+
case 1: case 2: case 4: case 8:
1579+
arg->arg_bitshift = 64 - arg_sz * 8;
1580+
break;
1581+
default:
1582+
pr_warn("usdt: unsupported arg #%d (spec '%s') size: %d\n",
1583+
arg_num, arg_str, arg_sz);
1584+
return -EINVAL;
1585+
}
1586+
1587+
return len;
1588+
}
1589+
15081590
#else
15091591

15101592
static int parse_usdt_arg(const char *arg_str, int arg_num, struct usdt_arg_spec *arg)

0 commit comments

Comments
 (0)