Track processes properly for perf record --off-cpu (v2) #3480

kernel-patches-bot · 2022-08-12T09:07:22Z

Pull request for series with
subject: Track processes properly for perf record --off-cpu (v2)
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=666979

kernel-patches-bot · 2022-08-12T09:07:23Z

Master branch: 10b62d6
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=666979
version: 1

kernel-patches-bot · 2022-08-15T15:35:16Z

Master branch: 54c9397
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=666979
version: 1

kernel-patches-bot · 2022-08-15T15:42:31Z

Master branch: 4961d07
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=666979
version: 1

Current task filter checks task->pid which is different for each thread. But we want to profile all the threads in the process. So let's compare process id (or thread-group id: tgid) instead. Before: $ sudo perf record --off-cpu -- perf bench sched messaging -t $ sudo perf report --stat | grep -A1 offcpu offcpu-time stats: SAMPLE events: 2 After: $ sudo perf record --off-cpu -- perf bench sched messaging -t $ sudo perf report --stat | grep -A1 offcpu offcpu-time stats: SAMPLE events: 850 Signed-off-by: Namhyung Kim <[email protected]>

The current target code uses thread id for tracking tasks because perf_events need to be opened for each task. But we can use tgid in BPF maps and check it easily. Signed-off-by: Namhyung Kim <[email protected]>

When -p option used or a workload is given, it needs to handle child processes. The perf_event can inherit those task events automatically. We can add a new BPF program in task_newtask tracepoint to track child processes. Before: $ sudo perf record --off-cpu -- perf bench sched messaging $ sudo perf report --stat | grep -A1 offcpu offcpu-time stats: SAMPLE events: 1 After: $ sudo perf record -a --off-cpu -- perf bench sched messaging $ sudo perf report --stat | grep -A1 offcpu offcpu-time stats: SAMPLE events: 856 Signed-off-by: Namhyung Kim <[email protected]>

kernel-patches-bot · 2022-08-15T18:46:28Z

Master branch: cea5588
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=666979
version: 1

Record off-cpu data with perf bench sched messaging workload and count the number of offcpu-time events. Also update the test script not to run next tests if failed already and revise the error messages. $ sudo ./perf test offcpu -v 88: perf record offcpu profiling tests : --- start --- test child forked, pid 344780 Checking off-cpu privilege Basic off-cpu test Basic off-cpu test [Success] Child task off-cpu test Child task off-cpu test [Success] test child finished with 0 ---- end ---- perf record offcpu profiling tests: Ok Signed-off-by: Namhyung Kim <[email protected]>

kernel-patches-bot · 2022-08-15T19:02:04Z

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=666979 irrelevant now. Closing PR.

…arations) Fix checkpatch code style warnings: WARNING: Missing a blank line after declarations kernel-patches#761: FILE: net/core/pktgen.c:761: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#780: FILE: net/core/pktgen.c:780: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#806: FILE: net/core/pktgen.c:806: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#823: FILE: net/core/pktgen.c:823: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#1968: FILE: net/core/pktgen.c:1968: + char f[32]; + memset(f, 0, 32); WARNING: Missing a blank line after declarations kernel-patches#2410: FILE: net/core/pktgen.c:2410: + struct pktgen_net *pn = net_generic(dev_net(pkt_dev->odev), pg_net_id); + if (!x) { WARNING: Missing a blank line after declarations kernel-patches#2442: FILE: net/core/pktgen.c:2442: + __u16 t; + if (pkt_dev->flags & F_QUEUE_MAP_RND) { WARNING: Missing a blank line after declarations kernel-patches#2523: FILE: net/core/pktgen.c:2523: + unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) WARNING: Missing a blank line after declarations kernel-patches#2567: FILE: net/core/pktgen.c:2567: + __u32 t; + if (pkt_dev->flags & F_IPSRC_RND) WARNING: Missing a blank line after declarations kernel-patches#2587: FILE: net/core/pktgen.c:2587: + __be32 s; + if (pkt_dev->flags & F_IPDST_RND) { WARNING: Missing a blank line after declarations kernel-patches#2634: FILE: net/core/pktgen.c:2634: + __u32 t; + if (pkt_dev->flags & F_TXSIZE_RND) { WARNING: Missing a blank line after declarations kernel-patches#2736: FILE: net/core/pktgen.c:2736: + int i; + for (i = 0; i < pkt_dev->cflows; i++) { WARNING: Missing a blank line after declarations kernel-patches#2738: FILE: net/core/pktgen.c:2738: + struct xfrm_state *x = pkt_dev->flows[i].x; + if (x) { WARNING: Missing a blank line after declarations kernel-patches#2752: FILE: net/core/pktgen.c:2752: + int nhead = 0; + if (x) { WARNING: Missing a blank line after declarations kernel-patches#2795: FILE: net/core/pktgen.c:2795: + unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) WARNING: Missing a blank line after declarations kernel-patches#3480: FILE: net/core/pktgen.c:3480: + ktime_t idle_start = ktime_get(); + schedule(); Signed-off-by: Peter Seiderer <[email protected]> Signed-off-by: NipaLocal <nipa@local>

…arations) Fix checkpatch code style warnings: WARNING: Missing a blank line after declarations kernel-patches#761: FILE: net/core/pktgen.c:761: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#780: FILE: net/core/pktgen.c:780: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#806: FILE: net/core/pktgen.c:806: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#823: FILE: net/core/pktgen.c:823: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations kernel-patches#1968: FILE: net/core/pktgen.c:1968: + char f[32]; + memset(f, 0, 32); WARNING: Missing a blank line after declarations kernel-patches#2410: FILE: net/core/pktgen.c:2410: + struct pktgen_net *pn = net_generic(dev_net(pkt_dev->odev), pg_net_id); + if (!x) { WARNING: Missing a blank line after declarations kernel-patches#2442: FILE: net/core/pktgen.c:2442: + __u16 t; + if (pkt_dev->flags & F_QUEUE_MAP_RND) { WARNING: Missing a blank line after declarations kernel-patches#2523: FILE: net/core/pktgen.c:2523: + unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) WARNING: Missing a blank line after declarations kernel-patches#2567: FILE: net/core/pktgen.c:2567: + __u32 t; + if (pkt_dev->flags & F_IPSRC_RND) WARNING: Missing a blank line after declarations kernel-patches#2587: FILE: net/core/pktgen.c:2587: + __be32 s; + if (pkt_dev->flags & F_IPDST_RND) { WARNING: Missing a blank line after declarations kernel-patches#2634: FILE: net/core/pktgen.c:2634: + __u32 t; + if (pkt_dev->flags & F_TXSIZE_RND) { WARNING: Missing a blank line after declarations kernel-patches#2736: FILE: net/core/pktgen.c:2736: + int i; + for (i = 0; i < pkt_dev->cflows; i++) { WARNING: Missing a blank line after declarations kernel-patches#2738: FILE: net/core/pktgen.c:2738: + struct xfrm_state *x = pkt_dev->flows[i].x; + if (x) { WARNING: Missing a blank line after declarations kernel-patches#2752: FILE: net/core/pktgen.c:2752: + int nhead = 0; + if (x) { WARNING: Missing a blank line after declarations kernel-patches#2795: FILE: net/core/pktgen.c:2795: + unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) WARNING: Missing a blank line after declarations kernel-patches#3480: FILE: net/core/pktgen.c:3480: + ktime_t idle_start = ktime_get(); + schedule(); Signed-off-by: Peter Seiderer <[email protected]> Reviewed-by: Toke Høiland-Jørgensen <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>

kernel-patches-bot added bpf-next new V1 labels Aug 12, 2022

kernel-patches-bot force-pushed the series/666979=>bpf-next branch from 3e81c23 to 495976b Compare August 15, 2022 15:35

kernel-patches-bot force-pushed the series/666979=>bpf-next branch from 495976b to f574e72 Compare August 15, 2022 15:42

Kernel Patches Daemon and others added 4 commits August 15, 2022 11:46

adding ci files

ef16444

perf offcpu: Parse process id separately

11940d7

The current target code uses thread id for tracking tasks because perf_events need to be opened for each task. But we can use tgid in BPF maps and check it easily. Signed-off-by: Namhyung Kim <[email protected]>

kernel-patches-bot force-pushed the series/666979=>bpf-next branch from f574e72 to f4ad265 Compare August 15, 2022 18:46

kernel-patches-bot added not-applicable and removed new labels Aug 15, 2022

kernel-patches-bot closed this Aug 15, 2022

kernel-patches-bot deleted the series/666979=>bpf-next branch August 15, 2022 19:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Track processes properly for perf record --off-cpu (v2) #3480

Track processes properly for perf record --off-cpu (v2) #3480

Uh oh!

kernel-patches-bot commented Aug 12, 2022

Uh oh!

kernel-patches-bot commented Aug 12, 2022

Uh oh!

kernel-patches-bot commented Aug 15, 2022

Uh oh!

kernel-patches-bot commented Aug 15, 2022

Uh oh!

kernel-patches-bot commented Aug 15, 2022

Uh oh!

kernel-patches-bot commented Aug 15, 2022

Uh oh!

Uh oh!

Track processes properly for perf record --off-cpu (v2) #3480

Track processes properly for perf record --off-cpu (v2) #3480

Uh oh!

Conversation

kernel-patches-bot commented Aug 12, 2022

Uh oh!

kernel-patches-bot commented Aug 12, 2022

Uh oh!

kernel-patches-bot commented Aug 15, 2022

Uh oh!

kernel-patches-bot commented Aug 15, 2022

Uh oh!

kernel-patches-bot commented Aug 15, 2022

Uh oh!

kernel-patches-bot commented Aug 15, 2022

Uh oh!

Uh oh!