Skip to content

Conversation

nuclearcat
Copy link
Member

Tested locally, now the rootfs.ext4 image is without errors.

@gctucker gctucker linked an issue Nov 9, 2021 that may be closed by this pull request
@gctucker gctucker requested a review from a team November 9, 2021 09:19
@gctucker
Copy link
Collaborator

gctucker commented Nov 9, 2021

@nuclearcat Please reformat the Git commit to follow the convention. For example (adjust with your own words...):

config/rootfs/debos: fix ext4 corrupt images

Fix ext4 file system image corruption by adding the postprocess
attribute to the steps that move the image file.

Link: https://github.com/kernelci/kernelci-core/issues/863
Signed-off-by: Denys Fedoryshchenko <[email protected]>

Fix ext4 file system image corruption by adding the postprocess
attribute to the steps that move the image file.

Link: #863
Signed-off-by: Denys Fedoryshchenko <[email protected]>
@nuclearcat
Copy link
Member Author

I think done. I hope i did not miss anything.

@gctucker
Copy link
Collaborator

gctucker commented Nov 9, 2021

Great. Have you tested this version locally as well, with the code blocks at the same place in the file?

We should have some rootfs images built on staging later today or tomorrow to confirm there's no unwanted side-effects in any case.

@nuclearcat
Copy link
Member Author

Not yet, I will test it in the next few hours.

@nuclearcat
Copy link
Member Author

All tests passed fine, image is bootable, dumpe2fs is clean.

@gctucker
Copy link
Collaborator

gctucker commented Nov 9, 2021

Great, thanks. I've started a buster amd64 build on staging, will check tomorrow if it worked as expected.

Copy link
Collaborator

@gctucker gctucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gctucker gctucker merged commit f68edce into kernelci:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debos.yaml sequence of commands causing ext4.rootfs corruption
2 participants