-
Notifications
You must be signed in to change notification settings - Fork 4
Track the Number of Messages #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…of messages we read in the readFile. Also, reserve the last 4 bytes at the end of the file for the number of messages in that file.
…ile now contains readMessages and writeMessages.
…omplete file and completely reading a file.
…writeMessages and readMessages in skipToNextRWFile.
…or disk space limit.
…t that these numbers are accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the other parts (e.g. the one documented in Next Steps
) will come in later PRs? if so it might worth updating this PR title to reflect the change. looks like it's mainly about counting the number of messages per file.
This reverts commit e9b23ac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update writeMessages and readMessages in handleReadError now?
Yes!!!! Nice catch! |
Implementation
Testing
Next Steps
Note
This pr will only handle the tracking of writeMessages and readMessages. The implementation of making space when we surpass the diskSizeLimit will come later.