Skip to content

Track disk size #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 14, 2021
Merged

Track disk size #5

merged 13 commits into from
Jun 14, 2021

Conversation

kev1n80
Copy link
Owner

@kev1n80 kev1n80 commented Jun 9, 2021

Implementation

  • If using the disk size limit feature
    • Track the number of bytes written that do not have the .bad file extension with writeBytes
    • Write writeBytes to MetaData

Testing

  • test that writeBytes increment after putting data
  • test that writeBytes decrements when a file is completely read

Next PR

  • implement disk size limit feature that will delete the oldest file first in order to make space

Copy link
Collaborator

@leonzz leonzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kev1n80 kev1n80 merged commit 6525bb0 into master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants