deps: update ChakraCore to chakra-core/ChakraCore@75ebad82b0

[MERGE #5482 @kfukuda2] Fixing labels, should throw syntax errors when labels are followed by lexical declarations Fixes nodejs#352

Merge pull request #5482 from kfukuda2:LabelsGrammarFix

Fixes nodejs#352

Reviewed-By: chakrabot <[email protected]>

Author: Kenji Fukuda

deps/chakrashim/core/lib/Parser/Parse.cpp

@@ -8442,6 +8442,10 @@ ParseNodePtr Parser::ParseExpr(int oplMin,
                 }
             }
         }
+        else if (nop == knopAwait && m_token.tk == tkColon)
+        {
+            Error(ERRAwaitAsLabelInAsync);
+        }
         else
         {
             // Disallow spread after a unary operator.
@@ -9573,6 +9577,7 @@ ParseNodePtr Parser::ParseStatement()
     uint fnop;
     bool expressionStmt = false;
     bool isAsyncMethod = false;
+    bool labelledStatement = false;
     tokens tok;
 #if EXCEPTION_RECOVERY
     ParseNodeTryCatch * pParentTryCatch = nullptr;
@@ -9625,6 +9630,10 @@ ParseNodePtr Parser::ParseStatement()
     switch (tok)
     {
     case tkEOF:
+        if (labelledStatement)
+        {
+            Error(ERRLabelFollowedByEOF);
+        }
         if (buildAST)
         {
             pnode = nullptr;
@@ -9646,6 +9655,25 @@ ParseNodePtr Parser::ParseStatement()
         {
             pnode = ParseFncDeclCheckScope<buildAST>(fFncDeclaration | (isAsyncMethod ? fFncAsync : fFncNoFlgs));
         }
+
+        Assert(pnode != nullptr);
+        ParseNodeFnc* pNodeFnc = (ParseNodeFnc*)pnode;
+        if (labelledStatement)
+        {
+            if (IsStrictMode())
+            {
+                Error(ERRFunctionAfterLabelInStrict);
+            }
+            else if (pNodeFnc->IsAsync())
+            {
+                Error(ERRLabelBeforeAsyncFncDeclaration);
+            }
+            else if (pNodeFnc->IsGenerator())
+            {
+                Error(ERRLabelBeforeGeneratorDeclaration);
+            }
+        }
+        
         if (isAsyncMethod)
         {
             pnode->AsParseNodeFnc()->cbMin = iecpMin;
@@ -9655,7 +9683,11 @@ ParseNodePtr Parser::ParseStatement()
     }
 
     case tkCLASS:
-        if (m_scriptContext->GetConfig()->IsES6ClassAndExtendsEnabled())
+        if (labelledStatement)
+        {
+            Error(ERRLabelBeforeClassDeclaration);
+        }
+        else if (m_scriptContext->GetConfig()->IsES6ClassAndExtendsEnabled())
         {
             pnode = ParseClassDecl<buildAST>(TRUE, nullptr, nullptr, nullptr);
         }
@@ -9668,6 +9700,10 @@ ParseNodePtr Parser::ParseStatement()
     case tkID:
         if (m_token.GetIdentifier(this->GetHashTbl()) == wellKnownPropertyPids.let)
         {
+            if (labelledStatement)
+            {
+                Error(ERRLabelBeforeLexicalDeclaration);
+            }
             // We see "let" at the start of a statement. This could either be a declaration or an identifier
             // reference. The next token determines which.
             RestorePoint parsedLet;
@@ -9701,6 +9737,10 @@ ParseNodePtr Parser::ParseStatement()
 
     case tkCONST:
     case tkLET:
+        if (labelledStatement)
+        {
+            Error(ERRLabelBeforeLexicalDeclaration);
+        }
         ichMin = this->GetScanner()->IchMinTok();
 
         this->GetScanner()->Scan();
@@ -10570,6 +10610,7 @@ ParseNodePtr Parser::ParseStatement()
                 pLabelId->next = pLabelIdList;
                 pLabelIdList = pLabelId;
                 this->GetScanner()->Scan();
+                labelledStatement = true;
                 goto LRestart;
             }
 

deps/chakrashim/core/lib/Parser/perrors.h

@@ -102,3 +102,10 @@ LSC_ERROR_MSG(1087, ERRInvalidExportName, "Unable to resolve module export name"
 LSC_ERROR_MSG(1088, ERRLetIDInLexicalDecl, "'let' is not an allowed identifier in lexical declarations")
 
 LSC_ERROR_MSG(1089, ERRInvalidLHSInFor, "Invalid left-hand side in for loop")
+LSC_ERROR_MSG(1090, ERRLabelBeforeLexicalDeclaration, "Labels not allowed before lexical declaration")
+LSC_ERROR_MSG(1091, ERRLabelBeforeGeneratorDeclaration, "Labels not allowed before generator declaration")
+LSC_ERROR_MSG(1092, ERRLabelBeforeAsyncFncDeclaration, "Labels not allowed before async function declaration")
+LSC_ERROR_MSG(1093, ERRLabelBeforeClassDeclaration, "Labels not allowed before class declaration")
+LSC_ERROR_MSG(1094, ERRLabelFollowedByEOF, "Unexpected end of script after a label.")
+LSC_ERROR_MSG(1095, ERRFunctionAfterLabelInStrict, "Function declarations not allowed after a label in strict mode.")
+LSC_ERROR_MSG(1096, ERRAwaitAsLabelInAsync, "Use of 'await' as label in async function is not allowed.")