This repository was archived by the owner on Oct 15, 2020. It is now read-only.
build: fix build break when omitting icu #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunalspathak
approved these changes
Aug 1, 2017
digitalinfinity
approved these changes
Aug 1, 2017
When building without ICU (`vcbuild.bat intl-none`) the unicode/ucnv.h header is not available, which caused compilation errors prior to this change. PR-URL: nodejs#352 Reviewed-By: Kunal Pathak <[email protected]>
|
Should this be done upstream? |
MSLaguana
force-pushed
the
fixArmBuildBreak
branch
from
46c4611 to
8a8e084
Compare
|
It is: nodejs/node#14533 I just want to unblock our CI ASAP |
|
landed upstream in nodejs/node@1782b38 |
chakrabot
pushed a commit
that referenced
this pull request
Jul 24, 2018
[MERGE #5482 @kfukuda2] Fixing labels, should throw syntax errors when labels are followed by lexical declarations Fixes #352 Merge pull request #5482 from kfukuda2:LabelsGrammarFix Fixes #352 Reviewed-By: chakrabot <[email protected]>
chakrabot
pushed a commit
that referenced
this pull request
Jul 24, 2018
[1.10>master] [MERGE #5482 @kfukuda2] Fixing labels, should throw syntax errors when labels are followed by lexical declarations Fixes #352 Merge pull request #5482 from kfukuda2:LabelsGrammarFix Fixes #352 Reviewed-By: chakrabot <[email protected]>
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Jul 24, 2018
[MERGE #5482 @kfukuda2] Fixing labels, should throw syntax errors when labels are followed by lexical declarations Fixes nodejs#352 Merge pull request #5482 from kfukuda2:LabelsGrammarFix Fixes nodejs#352 Reviewed-By: chakrabot <[email protected]>
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Jul 24, 2018
[MERGE #5482 @kfukuda2] Fixing labels, should throw syntax errors when labels are followed by lexical declarations Fixes nodejs#352 Merge pull request #5482 from kfukuda2:LabelsGrammarFix Fixes nodejs#352 Reviewed-By: chakrabot <[email protected]>
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Jul 25, 2018
[MERGE #5482 @kfukuda2] Fixing labels, should throw syntax errors when labels are followed by lexical declarations Fixes nodejs#352 Merge pull request #5482 from kfukuda2:LabelsGrammarFix Fixes nodejs#352 Reviewed-By: chakrabot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build