Improve Gemini Response Reliability #1148
Merged
+92
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
debanjum
commented
Apr 2, 2025
•
debanjum
commented
- Specify min, max number of list items expected in AI response via json schema enforcement
- Warn and drop invalid/empty messages when format messages for Gemini models
- Make Gemini response adhere to the order of the schema property definitions
- Improve agent creation safety checker by using response schema, better prompt
debanjum
force-pushed
the
specify-expected-items-count-via-json-schema-for-gemini-models
branch
3 times, most recently
from
670c4ff to
a88ec1d
Compare
Previously we were setting message content part with empty text. This results in error from Gemini API. Warn and drop such messages instead. Log empty message content found during construction to root-cause the issue but allow Khoj to respond without the offending messages in context for call to Gemini API.
debanjum
force-pushed
the
specify-expected-items-count-via-json-schema-for-gemini-models
branch
from
a88ec1d to
53d436e
Compare
Require at least 1 item in lists. Otherwise gemini flash will sometimes return an empty list. For chat actors where max items is known, set that as well. OpenAI API does not support specifying min, max items in response schema lists, so drop those properties when response schema is passed. Add other enforcements to response schema to comply with response schema format expected by OpenAI API.
…itions Without explicitly using the property ordering field, gemini returns responses in alphabetically sorted property order. We want the model to respect the schema property definition order. This ensures control during development to maintain response quality. For example in CoT make it fill scratchpad before answers.
debanjum
force-pushed
the
specify-expected-items-count-via-json-schema-for-gemini-models
branch
from
53d436e to
aab0107
Compare
debanjum
deleted the
specify-expected-items-count-via-json-schema-for-gemini-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.