Skip to content

perf(RNG): use strict less on pre-merge check #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf(RNG): use strict less on pre-merge check #367

wants to merge 1 commit into from

Conversation

greenlucid
Copy link

@greenlucid greenlucid commented Sep 7, 2022 •
edited
Loading

saves at least 6 gas. "less or equal" does not exist in the evm as a separate opcode, so to get the same effect, the compiler:

  • does a >, and does a ! on the result.
  • does a <, then a ==, then || both.

both variants need some stack manipulation, and take extra ops. but, you can just to a < check of the immediately larger value.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@greenlucid greenlucid changed the title perf(RNG): use strict less than on pre-merge check perf(RNG): use strict less on pre-merge check Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@greenlucid