-
Notifications
You must be signed in to change notification settings - Fork 21
feat: june treasury reports #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new treasury report entry for June 2025 was added at the beginning of the Changes
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/pages/treasury.js (1)
10-14
: (Nit) Keep the dataset internally consistent.For easier machine processing later, consider storing
year
as a number instead of a string across all rows.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/pages/treasury.js
(1 hunks)
🔇 Additional comments (1)
src/pages/treasury.js (1)
10-14
: Verify that the bare IPFS hash is sufficient — older rows include the file path/filename.Every prior
treasuryReport
value appends/<filename>.pdf
after the CID, while the newly-added June 2025 row contains only the CID.
getReportLink()
simply prefixeshttps://cdn.kleros.link/ipfs/
, so the resulting URL for June 2025 will be:https://cdn.kleros.link/ipfs/QmXz4BcqiXxpAcceZn7fzy38qVpTuTRVJSmxh9kkMSRUaH
If the PDF isn’t located at the root of that CID, the download will 404.
Would you double-check that the CID alone resolves to the intended PDF, or update the entry to include the full
/path/to/file.pdf
as the other rows do?
Summary by CodeRabbit