-
Notifications
You must be signed in to change notification settings - Fork 21
chore: add Guenter to fellows #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughAdds a new team member, Guenter Schramm Tronca, across the site: updates siteMetadata in gatsby-config.js, adds a markdown bio page, and registers the member’s photo in fellowship and bio templates to enable rendering of their profile and image. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
gatsby-config.js (1)
345-346
: Optional: include location and links for richer UIIf available, consider adding location (shown in the fellowship overlay) and social links for consistency with other entries.
- { name: "Guenter Schramm Tronca", title: "Lawyer", batch: 7 }, + { + name: "Guenter Schramm Tronca", + title: "Lawyer", + batch: 7, + // location: "Spain", // e.g., if you want to display this in the grid overlay + // links: { linkedin: "", x: "", github: "" } + },If you share the correct location/links, I can push a follow-up patch.
src/markdown-pages/tronca.md (1)
7-15
: Minor style nit: streamline the last sentenceOptional stylistic tweak to tighten the last paragraph by removing the parenthetical pause “, in recent years,”.
-Thanks to his extensive international legal experience and his fluency in English, Spanish, and German, he has, in recent years, specialized in urban planning and real estate law, with a focus on both national and international real estate transactions. +Thanks to his extensive international legal experience and his fluency in English, Spanish, and German, he has specialized in urban planning and real estate law, with a focus on both national and international real estate transactions.src/pages/fellowship.js (1)
83-83
: PHOTOS mapping entry — LGTMIncluding Tronca here ensures the grid can render the portrait for the new fellow.
To avoid duplication across files, consider centralizing the PHOTOS mapping in a shared module (e.g., src/components/photos.js) and importing it in both fellowship.js and bio.js. This reduces drift when adding future fellows.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
src/assets/images/person/tronca.png
is excluded by!**/*.png
📒 Files selected for processing (4)
gatsby-config.js
(1 hunks)src/markdown-pages/tronca.md
(1 hunks)src/pages/fellowship.js
(2 hunks)src/templates/bio.js
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
src/markdown-pages/tronca.md
[style] ~15-~15: Consider using a synonym to be more concise.
Context: ...n English, Spanish, and German, he has, in recent years, specialized in urban planning and real...
(IN_RECENT_STYLE)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - kleros-website
- GitHub Check: Header rules - kleros-website
- GitHub Check: Pages changed - kleros-website
🔇 Additional comments (5)
gatsby-config.js (1)
345-346
: New fellow entry added — LGTMThe new entry for "Guenter Schramm Tronca" with title "Lawyer" and batch 7 is correctly structured and consistent with the existing data shape.
src/markdown-pages/tronca.md (1)
1-6
: ✅ All wiring and links verified — LGTM
- Portrait asset
tronca.png
found atsrc/assets/images/person/tronca.png
- Imports present in
src/templates/bio.js
andsrc/pages/fellowship.js
Tronca
included in bothPHOTOS
(bio.js) andFELLOWS
(fellowship.js) mappings- Both
report
andspanishReport
URLs return HTTP 200src/templates/bio.js (2)
38-38
: Portrait import for Tronca — LGTMThe import path and casing match the expected asset and keying convention.
67-67
: PHOTOS entry for Tronca verified and asset file present — LGTM
- Import at src/templates/bio.js:38
- PHOTOS includes
Tronca
at src/templates/bio.js:67- Image file exists at src/assets/images/person/tronca.png
src/pages/fellowship.js (1)
47-47
: Portrait import — LGTMThe added import is consistent with existing portrait imports.
|
Summary by CodeRabbit