-
Notifications
You must be signed in to change notification settings - Fork 21
feat: treasury august #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdded a new entry for August 2025 at the start of the MONTHS array in src/pages/treasury.js with a treasuryReport CID; no riskReport field was included. No other code or exports were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
src/pages/treasury.js (3)
10-14
: Consistency: prior entries mostly include a filename after the CID.If the asset is stored under a directory CID, append the actual filename for consistency and to avoid CDN directory responses. If the CID is a file, keep as-is.
185-193
: Avoid non-ISO Date parsing for sorting.Sorting via
new Date("2025 August 1")
relies on implementation-dependent parsing. Prefer numeric compare on year/month indices.Apply:
- reports.sort((a, b) => { - const dateA = new Date(`${a.year} ${a.month} 1`); - const dateB = new Date(`${b.year} ${b.month} 1`); - return dateB - dateA; - }); + const MONTH_INDEX = { + January: 0, February: 1, March: 2, April: 3, May: 4, June: 5, + July: 6, August: 7, September: 8, October: 9, November: 10, December: 11 + }; + reports.sort((a, b) => { + const y = Number(b.year) - Number(a.year); + return y || (MONTH_INDEX[b.month] - MONTH_INDEX[a.month]); + });
280-282
: UX check: missing Aug 2025 risk report is intentional?With no
riskReport
for 2025 months, the Risk dropdown defaults to Dec 2024. Confirm that this is the desired behavior until a new risk report is added.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/pages/treasury.js
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - kleros-website
- GitHub Check: Header rules - kleros-website
- GitHub Check: Pages changed - kleros-website
🔇 Additional comments (2)
src/pages/treasury.js (2)
10-14
: LGTM: August 2025 entry added correctly.The new month entry is well-formed and placed in descending order before July 2025. No issues spotted.
10-14
: No changes needed. Confirmed https://cdn.kleros.link/ipfs/QmTccojcrgQekyU11xTV1z7ZbiyGs37zQsSbPAy6XZRqzx returns HTTP 200 withContent-Type: application/pdf
.
Summary by CodeRabbit