shared: Use unsigned char in hash calculation #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
evelikov
approved these changes
Nov 16, 2024
not very happy with changing the result... if we are changing I think we need to add some instrumentation and compare the amound of collisions we have with the current hash table size. Also... if we are changing, I'd rather add a pre step in which we (possibly) process the first element to get an aligned buffer on u16, so we don't have to use get_unaligned(). However most of our strings are really small, so I'm not sure it will make a noticeable difference. |
lucasdemarchi
pushed a commit
that referenced
this pull request
Nov 21, 2024
If newly created module in kmod_module_new could not be added to hash, return an error. Otherwise it is possible to create multiple independent structs with the same name, which the hash set is supposed to prevent. An error only occurs in out of memory conditions. Signed-off-by: Tobias Stoeckmann <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #248 Signed-off-by: Lucas De Marchi <[email protected]>
lucasdemarchi
pushed a commit
that referenced
this pull request
Nov 21, 2024
Follow up of aad7c69, which fixes the same issue in another function. Signed-off-by: Tobias Stoeckmann <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #248 Signed-off-by: Lucas De Marchi <[email protected]>
lucasdemarchi
pushed a commit
that referenced
this pull request
Nov 21, 2024
Use %zu for size_t, not %zd which would be for ssize_t. Signed-off-by: Tobias Stoeckmann <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #248 Signed-off-by: Lucas De Marchi <[email protected]>
|
Applied all but the first. Please rebase and let's continue the discussion on how to land this fix. |
Characters in key are supposed to be handled unsigned. Explicitly cast key[2] in case the key contains 8-bit ASCII. Even though we cannot support such keys in indices, we might still use them in module names and tools like modinfo. Signed-off-by: Tobias Stoeckmann <[email protected]>
lucasdemarchi
force-pushed
the
cleanups
branch
from
53a224a to
9803c44
Compare
stoeckmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted these while investigating #26.
Since these don't fix the issue but would basically lead all to a single PR, I've grouped them in a single one instead.