Modprobe from any for --show-{modversions,exports} #353
+71
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the functionality into a helper function, which will be used with later commits. Signed-off-by: Emil Velikov <[email protected]>
Signed-off-by: Emil Velikov <[email protected]>
Signed-off-by: Emil Velikov <[email protected]>
| @@ -203,6 +203,26 @@ static int show_config(struct kmod_ctx *ctx) | |||
| return 0; | |||
| } | |||
|
|
|||
| static int module_new_from_any(struct kmod_ctx *ctx, const char *module, struct kmod_module **mod, struct kmod_list **list) | |||
| { | |||
| if (strncmp(module, "/", 1) == 0 || strncmp(module, "./", 2) == 0) { | |||
There was a problem hiding this comment.
another opportunity for strstartswith?
| kmod_module_unref_list(list); | ||
| } | ||
| return err; | ||
|
|
There was a problem hiding this comment.
something wrong here...
|
I like the idea and functions names look fine for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the odd case of using --show/dump-modversions or --show-exports, I regularly get irked that they take only the full module path.
This PR fixes that, admittedly with zero testing, man/shell-completion updates... Looking at which, it seems like we never added
--show-exportsinto the man page - I'm guessing that was not intentional?If people are on board with the idea I will polish and resubmit. As always - name suggestions (see the helper functions within) are greatly appreciated.