Add sample for cloudevents-nodejs

[csantanapr]

Signed-off-by: Carlos Santana [email protected]

Fixes #2445

cc @lance @mattmoor

[mattmoor]

I'm no node expert, but a couple of drive-by comments.

Thanks for putting this together! 🎉

[lance]

So glad to see some of the upcoming API in use.

[lance]

"files.insertFinalNewline": true in VSCode config should enable auto insert of new line if one doesn’t exist. ;)

[csantanapr]

@mattmoor @lance let me know if this is good for now to merge this PR, I can do another update once the sdk 2.0 is out.

I think I'm done with the last changes, looks good that I can use as starting point to build a cool demo on top using brokers and triggers

[vaikas]

Awesome!!! Just couple of nits I think? Thanks!!

[csantanapr]

thanks @vaikas for the quick review, I think I addressed all your comments

[vaikas]

/lgtm
/hold
Holding since other folks had comments also, but thanks for doing this!!!

[csantanapr]

Ah its /hold I was looking for a way to put the PR in Draft for wip with /draft or /wip

[lance]

@csantanapr LGTM

[vaikas]

/unhold

[vaikas]

/approve

[mattmoor]

@csantanapr looks like you need another file, see the other PR that landed recently for the right way:

index_test.go:81: Could not verify docs: README.md missing bundle (you need an 'index.md' or '_index.md') in "docs/serving/samples/cloudevents/cloudevents-nodejs"

[mattmoor]

/unhold

I think the two things this needs are:

1. the license header
2. the index.md thing from the test failure

Otherwise I tried it with and without K_SINK and it worked great 🎉

[mattmoor]

We also need to update the table here: https://github.com/knative/docs/blob/master/docs/serving/samples/README.md

[csantanapr]

/hold

Thanks to all for reviewing the PR

I saw the other day from Evan on the refactor for the index.md and the testing for consistently +1

I will rebase and squash and update.

I was thinking on looking on adding functional e2e similar to the hello samples to avoid PITA manual testing but that would be a different PR

What you folks think on adding typescript version or Deno? Maybe one sample to cover both Deno and typescript ?

[mattmoor]

@csantanapr Ha! I was just asking about mirroring that test setup in #test now that these are expanding to more languages. I agree about doing that separately, and if you'd be willing to help drive that it'd be awesome!

[csantanapr]

@mattmoor yes I will also work on e2e tests good opportunity for me stop procrastinating and getting my hands dirty with some Go

[csantanapr]

/unhold

[csantanapr]

@mattmoor or @vaikas can you give this PR another look.
I tried to address all the feedback

[mattmoor]

/approve

Going to approve so the next push stages it :)

[csantanapr]

thanks @mattmoor I added license headers

[csantanapr]

And no # Foo to be found 😅

[lance]

cloudevents/sdk-javascript#178

[csantanapr]

@mattmoor bump

[mattmoor]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csantanapr, mattmoor, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mattmoor,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment