Skip to content

[release-1.12] Update linter config to new schema #14847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #14691

@knative-prow knative-prow bot requested review from jsanin-vmw and skonto January 30, 2024 17:44
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 30, 2024
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
Copy link

knative-prow bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1bd929) 86.00% compared to head (fb75ea2) 86.02%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12   #14847      +/-   ##
================================================
+ Coverage         86.00%   86.02%   +0.02%     
================================================
  Files               197      197              
  Lines             14922    14922              
================================================
+ Hits              12833    12836       +3     
+ Misses             1778     1776       -2     
+ Partials            311      310       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

/override "test (v1.26.x, kourier-tls, e2e)"

Copy link

knative-prow bot commented Jan 30, 2024

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • test (v1.26.x, kourier-tls, e2e)

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • build-tests_serving_release-1.12
  • istio-latest-no-mesh-tls_serving_release-1.12
  • istio-latest-no-mesh_serving_release-1.12
  • style / Golang
  • style / suggester / github_actions
  • style / suggester / shell
  • test (v1.28.x, istio-ambient, runtime)
  • tide
  • unit-tests_serving_release-1.12
  • upgrade-tests_serving_release-1.12

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "test (v1.26.x, kourier-tls, e2e)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

/override "test (v1.28.x, istio-ambient, runtime)"

Copy link

knative-prow bot commented Jan 30, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: test (v1.28.x, istio-ambient, runtime)

In response to this:

/override "test (v1.28.x, istio-ambient, runtime)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 0d199d9 into knative:release-1.12 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants