-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add support for CSI volumes #15815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @mwritescode! It looks like this is your first PR to knative/serving 🎉 |
|
Hi @mwritescode. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
| Message: `CSI volume support is disabled, but found CSI volume foo`, | ||
| }).Also( | ||
| &apis.FieldError{Message: "must not set the field(s)", Paths: []string{"csi"} | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwritescode could you pls take a look literals syntax in tests?
@dsimansk Generally I don't want to have serving e2e tests to cover PodSpec features. K8s community would have coverage there and it would make the serving suite even slower to run. I'm generally ok with stuff behind a feature flag because it's a buyer beware for teams that know what they are doing. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, mwritescode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (75.03%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #15815 +/- ##
==========================================
- Coverage 75.05% 75.03% -0.02%
==========================================
Files 222 222
Lines 18074 18092 +18
==========================================
+ Hits 13566 13576 +10
- Misses 4158 4165 +7
- Partials 350 351 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/override "codecov/project" it's fixed in main |
|
@dprotaso: Overrode contexts on behalf of dprotaso: codecov/project In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
Fixes #11069
Description
This feature introduces support for Container Storage Interface (CSI) volumes in Knative Serving, enabling users to integrate with a wide variety of storage solutions through the Kubernetes CSI standard. This enhancement allows Knative services to leverage enterprise storage systems, cloud provider volumes, and other storage implementations that support the CSI specification, while maintaining Knative's serverless principles.
Proposed Changes
Release Note