Fix flakiness in the autoscaler stat server tests #1758
Conversation
I changed the point when the test server address is notified. Prior this was done before calling http.Server::Serve. Because of this if http.Server::Shutdown finished before http.Server::Serve started - Serve would block indefinitely Now we notify the server address when net.Listener::Accept is invoked by the http.Server. This required tweaking how TCP keep alives are set on the connection
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dprotaso If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
size/M
|
The following is the coverage report on pkg/.
|
|
glyn is vacation for a week /assign @josephburnett |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, glyn, josephburnett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
I changed the point when the test server address is notified.
Prior this was done before calling http.Server::Serve.
Because of this if http.Server::Shutdown finished before
http.Server::Serve started - Serve would block indefinitely
Now we notify the server address when net.Listener::Accept is
invoked by the http.Server. This required tweaking how TCP
keep alives are set on the connection
Fixes #1738
Ran
go test -v -count=100000 -run TestServerLifecycle