Convert chromium wheel delta to physical pixels on macOS

.ci.yaml

@@ -13,17 +13,6 @@ enabled_branches:
 platform_properties:
   linux:
     properties:
-      build_host: "false"
-      build_fuchsia: "false"
-      build_android_debug: "false"
-      build_android_aot: "false"
-      build_android_vulkan: "false"
-      build_ios: "false"
-      build_android_jit_release: "false"
-      gcs_goldens_bucket: ""
-      ios_debug: "false"
-      ios_profile: "false"
-      ios_release: "false"
       # CIPD flutter/java/openjdk/$platform
       dependencies: >-
         [
@@ -35,25 +24,14 @@ platform_properties:
       cores: "8"
   mac:
     properties:
-      build_host: "false"
-      build_fuchsia: "false"
-      build_android_debug: "false"
-      build_android_aot: "false"
-      build_android_vulkan: "false"
-      build_ios: "false"
-      build_android_jit_release: "false"
-      gcs_goldens_bucket: ""
-      ios_debug: "false"
-      ios_profile: "false"
-      ios_release: "false"
       # CIPD flutter/java/openjdk/$platform
       dependencies: >-
         [
           {"dependency": "open_jdk", "version": "version:17"}
         ]
       device_type: none
       cpu: x86
-      os: Mac-12
+      os: Mac-12|Mac-13
       # TODO(vashworth): Remove specific toolchain_ver once https://github.com/flutter/flutter/issues/138109 is resolved.
       $flutter/osx_sdk : >-
         {
@@ -65,17 +43,6 @@ platform_properties:
       mac_model: "Macmini8,1|Macmini9,1"
   windows:
     properties:
-      build_host: "false"
-      build_fuchsia: "false"
-      build_android_debug: "false"
-      build_android_aot: "false"
-      build_android_vulkan: "false"
-      build_ios: "false"
-      build_android_jit_release: "false"
-      gcs_goldens_bucket: ""
-      ios_debug: "false"
-      ios_profile: "false"
-      ios_release: "false"
       # CIPD flutter/java/openjdk/$platform
       dependencies: >-
         [
@@ -94,6 +61,7 @@ targets:
     timeout: 60
     runIf:
       - .ci.yaml
+      - DEPS
       - lib/ui/**
       - shell/platform/android/**
 
@@ -164,25 +132,6 @@ targets:
       config_name: linux_benchmarks
     timeout: 60
 
-  - name: Linux Fuchsia
-    bringup: true
-    recipe: engine/engine
-    properties:
-      build_fuchsia: "true"
-      fuchsia_ctl_version: version:0.0.27
-      # ensure files from pre-production Fuchsia SDK tests are purged from cache
-      clobber: "true"
-    timeout: 90
-    # TODO(https://github.com/flutter/flutter/issues/138559): Re-enable/delete.
-    # runIfNot:
-    #   - lib/web_ui/**
-    #   - shell/platform/android/**
-    #   - shell/platform/darwin/**
-    #   - shell/platform/glfw/**
-    #   - shell/platform/linux/**
-    #   - shell/platform/windows/**
-    #   - web_sdk/**
-
   - name: Linux Fuchsia FEMU
     recipe: engine/femu_test
     properties:
@@ -251,7 +200,6 @@ targets:
 
   - name: Linux linux_clang_tidy
     recipe: engine_v2/engine_v2
-    presubmit: false
     timeout: 120
     properties:
       config_name: linux_clang_tidy
@@ -268,24 +216,6 @@ targets:
       - "**.frag"
       - "**.vert"
 
-  - name: Linux linux_clang_tidy_presubmit
-    recipe: engine_v2/engine_v2
-    timeout: 120
-    properties:
-      config_name: linux_clang_tidy_presubmit
-    runIf:
-      - DEPS
-      - .ci.yaml
-      - tools/clang_tidy/**
-      - ci/builders/**
-      - ci/clang_tidy.sh
-      - "**.h"
-      - "**.c"
-      - "**.cc"
-      - "**.fbs"
-      - "**.frag"
-      - "**.vert"
-
   - name: Linux linux_arm_host_engine
     recipe: engine_v2/engine_v2
     timeout: 120
@@ -406,7 +336,6 @@ targets:
 
   - name: Mac mac_clang_tidy
     recipe: engine_v2/engine_v2
-    presubmit: false
     timeout: 120
     properties:
       config_name: mac_clang_tidy
@@ -425,26 +354,6 @@ targets:
       - "**.m"
       - "**.mm"
 
-  - name: Mac mac_clang_tidy_presubmit
-    recipe: engine_v2/engine_v2
-    timeout: 120
-    properties:
-      config_name: mac_clang_tidy_presubmit
-    runIf:
-      - DEPS
-      - .ci.yaml
-      - tools/clang_tidy/**
-      - ci/builders/**
-      - ci/clang_tidy.sh
-      - "**.h"
-      - "**.c"
-      - "**.cc"
-      - "**.fbs"
-      - "**.frag"
-      - "**.vert"
-      - "**.m"
-      - "**.mm"
-
   - name: Mac mac_host_engine
     recipe: engine_v2/engine_v2
     timeout: 120
@@ -465,7 +374,7 @@ targets:
           "toolchain_ver_intel": "Zp2HmSx7_-pu-yHqYqzoEpo0JRwNZGGwSj5V1SnLFmoC"
         }
     drone_dimensions:
-      - os=Mac-12
+      - os=Mac-12|Mac-13
 
   - name: Linux mac_unopt
     recipe: engine_v2/engine_v2
@@ -489,7 +398,7 @@ targets:
           "toolchain_ver_intel": "Zp2HmSx7_-pu-yHqYqzoEpo0JRwNZGGwSj5V1SnLFmoC"
         }
     drone_dimensions:
-      - os=Mac-12
+      - os=Mac-12|Mac-13
       - cpu=x86
 
   - name: Mac impeller-cmake-example

.github/labeler.yml

@@ -4,37 +4,57 @@
 
 # See https://github.com/actions/labeler/blob/main/README.md for docs.
 'affects: desktop':
-  - shell/platform/darwin/common/**/*
-  - shell/platform/darwin/macos/**/*
-  - shell/platform/linux/**/*
-  - shell/platform/windows/**/*
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/darwin/common/**/*
+      - shell/platform/darwin/macos/**/*
+      - shell/platform/linux/**/*
+      - shell/platform/windows/**/*
 
 embedder:
-  - shell/platform/embedder
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/embedder
 
 'e: impeller':
-  - impeller/**/*
+  - changed-files:
+    - any-glob-to-any-file:
+      - impeller/**/*
 
 platform-android:
-  - shell/platform/android/**/*
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/android/**/*
 
 platform-ios:
-  - shell/platform/darwin/common/**/*
-  - shell/platform/darwin/ios/**/*
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/darwin/common/**/*
+      - shell/platform/darwin/ios/**/*
 
 platform-fuchsia:
-  - shell/platform/fuchsia/**/*
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/fuchsia/**/*
 
 platform-linux:
-  - shell/platform/linux/**/*
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/linux/**/*
 
 platform-macos:
-  - shell/platform/darwin/common/**/*
-  - shell/platform/darwin/macos/**/*
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/darwin/common/**/*
+      - shell/platform/darwin/macos/**/*
 
 platform-web:
-  - lib/web_ui/**/*
-  - '**/web_sdk/**/*'
+  - changed-files:
+    - any-glob-to-any-file:
+      - lib/web_ui/**/*
+      - '**/web_sdk/**/*'
 
 platform-windows:
-  - shell/platform/windows/**/*
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/windows/**/*

.github/workflows/labeler.yml

@@ -17,4 +17,4 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     # Source available at https://github.com/actions/labeler/blob/main/README.md
-    - uses: actions/labeler@ac9175f8a1f3625fd0d4fb234536d26811351594
+    - uses: actions/labeler@8558fd74291d67161a8a78ce36a881fa63b766a9

.github/workflows/third_party_scan.yml

@@ -29,7 +29,7 @@ jobs:
         with:
           persist-credentials: false
       - name: "setup python"
-        uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236
+        uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c
         with:
           python-version: '3.7.7' # install the python version needed
       - name: "extract and flatten deps"

BUILD.gn

@@ -201,6 +201,7 @@ group("unittests") {
       public_deps += [
         "//flutter/impeller/golden_tests:impeller_golden_tests",
         "//flutter/shell/gpu:gpu_surface_metal_unittests",
+        "//flutter/shell/platform/darwin/common:availability_version_check_unittests",
         "//flutter/shell/platform/darwin/common:framework_common_unittests",
         "//flutter/third_party/spring_animation:spring_animation_unittests",
       ]