Fix result images being rescaled on HDPI monitors #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in Gwenview (which uses kImageAnnotator), when using the annotate feature on devices with Display Scaling enabled, the resulting image gets rescaled as well; e.g. if one starts annotating a 10x10 image on a 125%-scaled monitor, they would get a 20x20 image after annotating: KDE bug 485066
I considered changing the pixel ratio of the image coming from Gwenview in https://github.com/KDE/gwenview/blob/fa8a60a7988504feafe78c4d39c2ad362b31ad56/lib/annotate/annotatedialog.cpp#L53 to match the device pixel ratio instead, however doing so ends up adding a border of white pixels around odd-sized images (e.g. 11x11 becomes 12x12), and also doubles annotation sizes (e.g. 3-width pencil tool ends up taking 4 pixels).
I also tested this change with
ksnip(with the xdg-portal based grabber), and it seemed to work fine as long as "scale generic wayland screenshots" is enabled.BTW, this PR was made during a livestream, starting at 00:11:50. You can see me testing with ksnip around 01:30:21.