Skip to content

Support VM Network Multi-Queue in KubeVirt Provider #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2024
Merged

Support VM Network Multi-Queue in KubeVirt Provider #1874

merged 2 commits into from
Nov 8, 2024

Conversation

moadqassem
Copy link
Member

What this PR does / why we need it:
As the title reads, support and default to true for the KubeVirt VM Network Multi-Queue.
Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

support network multi queue in KubeVirt VM

Documentation:

none

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2024
@moadqassem moadqassem requested a review from yaa110 November 7, 2024 14:22
@moadqassem
Copy link
Member Author

@ronissac88 FYI

@yaa110
Copy link

yaa110 commented Nov 8, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3cc829a79cc0e43c43b2fd904cd4bb7fbe170819

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yaa110

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@kubermatic-bot kubermatic-bot merged commit b5a4e91 into kubermatic:main Nov 8, 2024
12 checks passed
@moadqassem moadqassem deleted the support-vm-multi-queue branch January 17, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaa110 yaa110 Awaiting requested review from yaa110

Assignees

@yaa110 yaa110

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moadqassem @yaa110 @kubermatic-bot