baremetal: Templating OSImage links through Tinkerbell workflow objects #1891
Conversation
kubermatic-bot
added
docs/none
|
/assign |
mohamed-rafraf
force-pushed
the
tmpl-osimage
branch
from
8170a8a to
6bd4b2c
Compare
pkg/cloudprovider/provider/baremetal/plugins/tinkerbell/client/workflow.go
Outdated
Show resolved
Hide resolved
|
/cherrypick release/v1.60 |
|
@mohamed-rafraf: once the present PR merges, I will cherry-pick it on top of release/v1.60 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
LGTM label has been added. Git tree hash: c2f04e414e7e5962483e0b09e8045b613fa83b0d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
@mohamed-rafraf: new pull request created: #1895 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Enable OSImageURL templating in workflows to support different OS images for each hardware server, as machine-controller creates templates only once.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: