-
Notifications
You must be signed in to change notification settings - Fork 138
Move APIs and cloud provider types into standalone Go module in ./sdk #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test all |
Skipping CI for Draft Pull Request. |
@xrstf: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
golangci-lint run --verbose --print-resources-usage ./... | ||
golangci-lint run --verbose --print-resources-usage --config ../.golangci.yml ./... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we run golangci-lint two times? Can you leave a comment in the Makefile why do we do this if this is intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic!
/lgtm
/approve
LGTM label has been added. Git tree hash: 76c519bdbb56d7320e8539c59219a4e2d9b54219
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release/v1.61 |
@soer3n: #1900 failed to apply on top of branch "release/v1.61":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
To make it easier to use the machine-controller's types and APIs, this PR moves the Kube APIs, cloud provider types, providerconfig and userdata into a new Go module in the
sdk
directory. Consumers can then simply importk8c.io/machine-controller/sdk
and avoid having to also import heavy cloud provider dependencies.No changes were made to the actual API definitions.
What type of PR is this?
/kind api-change
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: