Skip to content

Allow multi patch http content type header #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 17, 2020
Merged

Allow multi patch http content type header #521

merged 4 commits into from
Nov 17, 2020

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Nov 17, 2020 •
edited
Loading

  • ability to customize content-type
  • json patch and merge patch both supported.
  • remove asp json patch, now it is user's responsibility to wrap any object represent a patch to v1patch
  • e2e test for patch

follow up for #517

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 17, 2020
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit f59c13d into kubernetes-client:master Nov 17, 2020
@tg123 tg123 mentioned this pull request Nov 18, 2020
Merged
@tg123 tg123 deleted the better_patch branch November 19, 2020 11:49
@tg123 tg123 mentioned this pull request Apr 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tg123 @brendandburns @k8s-ci-robot