-
Notifications
You must be signed in to change notification settings - Fork 555
Fix packaging. #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix packaging. #346
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -9,6 +9,12 @@ | |||
"files": [ | |||
"dist/*.ts", | |||
"dist/*.js", | |||
"dist/gen/*.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.npmjs.com/files/package.json#files
Do you think we could do
"dist/**/*.js"
"dist/**/*.ts"
Wondering if this would be better then we don't need to remember as the folders change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that pull in the examples? e.g., dist/exec/
Use the below instead?
"dist/gen/**.js",
"dist/gen/**.ts"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silasbw Why would you want to explicitly only include gen?
Is there something different between what I suggested above here?
"dist/**/*.js"
"dist/**/*.ts"
Does that also do directory globbing as far as I know it only does current directory. |
oops, you're right. I meant:
|
2f4d401
to
f134596
Compare
Added the glob, please take another look. Thanks! |
/lgtm I still think it would be nicer to do "dist//*.js" But don't think it's a blocker and this fixes the actuall issue. |
We changed where we generate the code, but we didn't update package.json to include it in the npm package...
cc @drubin @silasbw