Skip to content

Fix packaging. #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Conversation

brendandburns
Copy link
Contributor

We changed where we generate the code, but we didn't update package.json to include it in the npm package...

cc @drubin @silasbw

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 25, 2019
@brendandburns brendandburns requested review from drubin and silasbw and removed request for itowlson and mbohlool September 25, 2019 05:07
@@ -9,6 +9,12 @@
"files": [
"dist/*.ts",
"dist/*.js",
"dist/gen/*.ts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.npmjs.com/files/package.json#files

Do you think we could do

"dist/**/*.js"
"dist/**/*.ts"

Wondering if this would be better then we don't need to remember as the folders change?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that pull in the examples? e.g., dist/exec/

Use the below instead?

"dist/gen/**.js",
"dist/gen/**.ts"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silasbw Why would you want to explicitly only include gen?

Is there something different between what I suggested above here?

"dist/**/*.js"
"dist/**/*.ts"

@drubin
Copy link
Contributor

drubin commented Sep 25, 2019

Does that also do directory globbing as far as I know it only does current directory.

@silasbw
Copy link

silasbw commented Sep 25, 2019

oops, you're right. I meant:

"dist/gen/**/*.js",
"dist/gen/**/*.ts"

@brendandburns
Copy link
Contributor Author

Added the glob, please take another look.

Thanks!

@drubin
Copy link
Contributor

drubin commented Sep 25, 2019

/lgtm

I still think it would be nicer to do

"dist//*.js"
"dist/
/*.ts"

But don't think it's a blocker and this fixes the actuall issue.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 339ed1f into kubernetes-client:master Sep 25, 2019
@brendandburns brendandburns deleted the package branch July 8, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants