Skip to content

Run e2e tests against against https url #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2017

Conversation

dims
Copy link
Collaborator

@dims dims commented Feb 3, 2017

Use hitch tls proxy to listen on 8443 port and forward the
traffic to 8080. Add a configuration option to ignore any
issues with host names as we don't generate the cert on the
fly.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2017
Use hitch tls proxy to listen on 8443 port and forward the
traffic to 8080. Add a configuration option to ignore any
issues with host names as we don't generate the cert on the
fly.
@dims dims force-pushed the ssl-based-e2e-tests branch from ae5cd63 to 96cfceb Compare February 3, 2017 17:17
.travis.yml Outdated
@@ -13,8 +13,14 @@ env:
- TOXENV=docs
- TOXENV=coverage,codecov

before_install:
- sudo add-apt-repository ppa:0k53d-karl-f830m/hitch -y
Copy link
Contributor

@mbohlool mbohlool Feb 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what that repository is but I think this is not the recommended way to use hitch. Reference: https://hitchtest.readthedocs.io/en/latest/howto/continuous_integration.html#travis

@dims
Copy link
Collaborator Author

dims commented Feb 7, 2017

@mbohlool : there are two projects with the same name. what i use is this (https://hitch-tls.org/) which is a TLS proxy to redirect from 8443 to 8080. The url you pasted is a test/ci framework :)

@mbohlool
Copy link
Contributor

mbohlool commented Feb 7, 2017

@dims I understand. Thanks. Where did you get the repo name ppa:0k5....? can you add a comment there to the reference page?

@codecov-io
Copy link

Codecov Report

Merging #121 into master will not impact coverage.

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files           9        9           
  Lines         668      668           
=======================================
  Hits          631      631           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3cd13...16d6da4. Read the comment docs.

@mbohlool mbohlool merged commit 192b67c into kubernetes-client:master Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants