Skip to content

Use swagger-codegen HEAD to generate the client #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 10, 2017

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented Oct 3, 2017

More information at issue: #341

This PR is depends on base client PR: kubernetes-client/python-base#34

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 3, 2017
@mbohlool mbohlool changed the title Use swagger-codegen HEAD to generate the client [WIP] Use swagger-codegen HEAD to generate the client Oct 4, 2017
@mbohlool mbohlool changed the title [WIP] Use swagger-codegen HEAD to generate the client Use swagger-codegen HEAD to generate the client Oct 6, 2017
@mbohlool mbohlool force-pushed the b1 branch 2 times, most recently from c33cb86 to d1b8969 Compare October 6, 2017 21:10
Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am assuming the first 2 change sets are machine generated :)

@mbohlool
Copy link
Contributor Author

mbohlool commented Oct 9, 2017

@dims, yes for the first one. Second one is almost generated, I only removed some file from ignore list so the generator generates them.

@mbohlool mbohlool merged commit 7e4b809 into kubernetes-client:master Oct 10, 2017
dulek pushed a commit to dulek/client-python that referenced this pull request Dec 5, 2017
This commit reapplies PR kubernetes-client#120 that was removed by kubernetes-client#353. Below is the
original commit message.

inspired by the POC from @chekolyn

* Adds a new requirement on websocket-client
* Add a new class WSClient that uses WebSocketApp from
  the websocket-client.
* Make sure we pass Authorization header
* Make sure we honor the SSL settings in configuration
* Some of the code will get overwritten when we generate
  fresh classes from swagger definition. To remind us
  added a e2e test so we don't lose the changes
* Added a new configuration option to enable/disable failures
  when hostnames in certificates don't match

Fixes kubernetes-client#58
Fixes kubernetes-client#409
dulek pushed a commit to dulek/client-python that referenced this pull request Dec 5, 2017
This commit reapplies PR kubernetes-client#120 that was removed by kubernetes-client#353. Below is the
original commit message.

inspired by the POC from @chekolyn

* Adds a new requirement on websocket-client
* Add a new class WSClient that uses WebSocketApp from
  the websocket-client.
* Make sure we pass Authorization header
* Make sure we honor the SSL settings in configuration
* Some of the code will get overwritten when we generate
  fresh classes from swagger definition. To remind us
  added a e2e test so we don't lose the changes
* Added a new configuration option to enable/disable failures
  when hostnames in certificates don't match

Fixes kubernetes-client#58
Fixes kubernetes-client#409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants