Skip to content

Enable volume stats #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2021
Merged

Enable volume stats #275

merged 1 commit into from
Apr 15, 2021

Conversation

stoneshi-yunify
Copy link
Contributor

Signed-off-by: stoneshi-yunify [email protected]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Without this PR, you can not get volume stats data provisioned by this driver

Which issue(s) this PR fixes:

Fixes #273

Special notes for your reviewer:
Also return the inodes usage data, not sure why former code did not do that.

Does this PR introduce a user-facing change?:

User now can get volume stats data with Prometheus

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @stoneshi-yunify!

It looks like this is your first PR to kubernetes-csi/csi-driver-host-path 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-host-path has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @stoneshi-yunify. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 15, 2021
@pohly
Copy link
Contributor

pohly commented Apr 15, 2021

/ok-to-test

Are there any tests for this functionality?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2021
@stoneshi-yunify
Copy link
Contributor Author

/ok-to-test

Are there any tests for this functionality?

No, currently there are no unit tests for controllerserver/identityserver/nodeserver. I think they will be covered by the CSI E2E tests.

Looks like some CSI E2E tests failed, I will look into it.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 15, 2021
@stoneshi-yunify
Copy link
Contributor Author

/retest

1 similar comment
@stoneshi-yunify
Copy link
Contributor Author

/retest

@stoneshi-yunify
enable volume stats
9e87c08 
Signed-off-by: stoneshi-yunify <[email protected]>
@stoneshi-yunify
Copy link
Contributor Author

/retest

@stoneshi-yunify
Copy link
Contributor Author

/cc @pohly

@k8s-ci-robot k8s-ci-robot requested a review from pohly April 15, 2021 09:21
@pohly
Copy link
Contributor

pohly commented Apr 15, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, stoneshi-yunify

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit e5b3bca into kubernetes-csi:master Apr 15, 2021
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/csi-driver-host-path that referenced this pull request Jul 10, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 04965932..74e066a8
4946046 
74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7 Update CSI prow driver version to v1.17.0
0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af10153 update to go 1.24.4
f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db Remove chrishenzie from kubernetes-csi-reviewers
0a435bf9 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34b Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e Bump golang to 1.24.0
f277d561 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a5 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
@Aishwarya-Hebbar Aishwarya-Hebbar mentioned this pull request Jul 10, 2025
Closed
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/csi-driver-host-path that referenced this pull request Jul 14, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 04965932..74e066a8
22b4509 
74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7 Update CSI prow driver version to v1.17.0
0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af10153 update to go 1.24.4
f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db Remove chrishenzie from kubernetes-csi-reviewers
0a435bf9 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34b Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e Bump golang to 1.24.0
f277d561 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a5 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
darshansreenivas pushed a commit to darshansreenivas/csi-driver-host-path that referenced this pull request Oct 15, 2025
Squashed 'release-tools/' changes from 0a435bf9..74502e54
e0daa65 
74502e54 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages
53344305 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5
458ce146 Bump actions/checkout from 4 to 5
5f38a907 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6
579f6242 Update go to 1.24.6
5ec1a52b use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages
74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7 Update CSI prow driver version to v1.17.0
0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af10153 update to go 1.24.4
f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db Remove chrishenzie from kubernetes-csi-reviewers

git-subtree-dir: release-tools
git-subtree-split: 74502e544bc6a17820892c0d490e8f0b59462998
darshansreenivas added a commit to darshansreenivas/csi-driver-host-path that referenced this pull request Oct 15, 2025
@darshansreenivas
Squashed 'release-tools/' changes from 0a435bf9..74502e54
b662168 
74502e54 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages
53344305 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5
458ce146 Bump actions/checkout from 4 to 5
5f38a907 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6
579f6242 Update go to 1.24.6
5ec1a52b use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages
74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7 Update CSI prow driver version to v1.17.0
0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af10153 update to go 1.24.4
f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db Remove chrishenzie from kubernetes-csi-reviewers

git-subtree-dir: release-tools
git-subtree-split: 74502e544bc6a17820892c0d490e8f0b59462998
@darshansreenivas darshansreenivas mentioned this pull request Oct 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 Awaiting requested review from msau42

@xing-yang xing-yang Awaiting requested review from xing-yang

@pohly pohly Awaiting requested review from pohly

Assignees

@pohly pohly

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hostpath driver does not export volume metrics

3 participants

@stoneshi-yunify @k8s-ci-robot @pohly