Skip to content

Conversation

mkimuram
Copy link

@mkimuram mkimuram commented Nov 7, 2019

What type of PR is this?
This enables prow.sh in csi-release-tool to run custom e2e tests.

What this PR does / why we need it:
This PR is needed for csi drivers that don't have dynamic provisioner, like NFS and iSCSI,
to run custom e2e binary in CI jobs.

Below are the status for cstom e2e binary codes in NFS and iSCSI driver:

Special notes for your reviewer:
@pohly @msau42 @mathu97

This PR is tested with below csi NFS driver repo (I found that kubernetes-csi/csi-driver-nfs#14 is doing almost the same thing, but it seems that it is not yet completed.).
https://github.com/mkimuram/csi-driver-nfs/tree/custom-e2e

Below commands will make custom e2e tests for csi NFS driver from .prow.sh in above csi-drver-nfs repo.

# sed -i -e 's/#CSI_PROW_BUILD_JOB=/CSI_PROW_BUILD_JOB=/' -e 's/#CSI_PROW_TESTS=/CSI_PROW_TESTS=/' .prow.sh
# export GO111MODULE=on
# ./.prow.sh

I will make a PR for CSI NFS driver above, once this PR is merged.
(Also, I'm thinking about adding this to CSI iSCSI driver and enable CI job on test-infra repo, as commented in kubernetes-csi/csi-driver-iscsi#17 (comment) .)

@k8s-ci-robot
Copy link
Contributor

@mkimuram: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @mkimuram!

It looks like this is your first PR to kubernetes-csi/csi-release-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-release-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @mkimuram. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkimuram
To complete the pull request process, please assign pohly
You can assign the PR to them by writing /assign @pohly in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tends to copy existing functions (like run_e2e) and then makes some change in it. Do you think you can come up with a solution that makes those functions more more generic such that they work for hostpath-driver based testing as well as other CSI drivers?

Same for the tests. For example, do you really need "serial" and "repo-custom-serial" or can "serial" be parameterized such that it tests the custom CSI driver?

@pohly
Copy link
Contributor

pohly commented Nov 7, 2019

kubernetes-csi/csi-driver-nfs#14 was complete, we just got stuck because the NFS driver didn't work in the Prow environment (kubernetes-csi/csi-driver-nfs#14 (comment)).

If you look at that PR, you'll see that it worked without modifying csi-release-tools. Are you sure that you need these modifications here?

@mkimuram
Copy link
Author

mkimuram commented Nov 8, 2019

@pohly

Thank you for your explanation.
I understand that modification is done on driver repo's .prow.sh and it should work.
This will be good enough, for there won't be so many drivers that require this modification.

I will consider applying the similar changes to csi-driver-iscsi.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 6, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 7, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants