-
Notifications
You must be signed in to change notification settings - Fork 81
Add custom e2e job to prow.sh #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mkimuram: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @mkimuram! |
Hi @mkimuram. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkimuram The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tends to copy existing functions (like run_e2e
) and then makes some change in it. Do you think you can come up with a solution that makes those functions more more generic such that they work for hostpath-driver based testing as well as other CSI drivers?
Same for the tests. For example, do you really need "serial" and "repo-custom-serial" or can "serial" be parameterized such that it tests the custom CSI driver?
kubernetes-csi/csi-driver-nfs#14 was complete, we just got stuck because the NFS driver didn't work in the Prow environment (kubernetes-csi/csi-driver-nfs#14 (comment)). If you look at that PR, you'll see that it worked without modifying csi-release-tools. Are you sure that you need these modifications here? |
Thank you for your explanation. I will consider applying the similar changes to csi-driver-iscsi. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
This enables prow.sh in csi-release-tool to run custom e2e tests.
What this PR does / why we need it:
This PR is needed for csi drivers that don't have dynamic provisioner, like NFS and iSCSI,
to run custom e2e binary in CI jobs.
Below are the status for cstom e2e binary codes in NFS and iSCSI driver:
Special notes for your reviewer:
@pohly @msau42 @mathu97
This PR is tested with below csi NFS driver repo (I found that kubernetes-csi/csi-driver-nfs#14 is doing almost the same thing, but it seems that it is not yet completed.).
https://github.com/mkimuram/csi-driver-nfs/tree/custom-e2e
Below commands will make custom e2e tests for csi NFS driver from .prow.sh in above csi-drver-nfs repo.
I will make a PR for CSI NFS driver above, once this PR is merged.
(Also, I'm thinking about adding this to CSI iSCSI driver and enable CI job on test-infra repo, as commented in kubernetes-csi/csi-driver-iscsi#17 (comment) .)