-
Notifications
You must be signed in to change notification settings - Fork 402
Closed
Labels
lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Description
During code review of #206, @msau42 raised a comment about verifying snapshot name length.
Verify what is the size limit for a snapshot name in CSI spec.
CSI Spec says 128 max: https://github.com/container-storage-interface/spec/blob/master/spec.md#size-limits. It also says length of the snapshot name conforms to the length limit of an unicode string.
message CreateSnapshotRequest {
// The suggested name for the snapshot. This field is REQUIRED for
// idempotency.
// Any Unicode string that conforms to the length limit is allowed
// except those containing the following banned characters:
// U+0000-U+0008, U+000B, U+000C, U+000E-U+001F, U+007F-U+009F.
// (These are control characters other than commonly used whitespace.)
string name = 2;
Should follow up on this.
Metadata
Metadata
Labels
lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.