Skip to content

Run multidistro windows build #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2021
Merged

Run multidistro windows build #146

merged 2 commits into from
Jun 2, 2021

Conversation

mauriciopoppe
Copy link
Member

@mauriciopoppe mauriciopoppe commented May 13, 2021 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:

Updates the release-tools and the Dockerfile.Windows files to support multi distro windows builds

Does this PR introduce a user-facing change?:

Dockerfile.Windows args changed to ADDON_IMAGE and BASE_IMAGE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 13, 2021
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 13, 2021
@mauriciopoppe
Copy link
Member Author

/uncc @saad-ali @vladimirvivien

@mauriciopoppe mauriciopoppe changed the title [WIP] run multidistro windows build Run multidistro windows build May 13, 2021
@mauriciopoppe mauriciopoppe marked this pull request as ready for review May 13, 2021 20:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2021
@mauriciopoppe
Copy link
Member Author

This is WIP, I'm just trying to trigger a build :)

@mauriciopoppe mauriciopoppe force-pushed the multidistro-windows-build branch 4 times, most recently from 1aa5713 to 182434d Compare May 13, 2021 21:42
@mauriciopoppe
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 14, 2021
@mauriciopoppe mauriciopoppe force-pushed the multidistro-windows-build branch from d8a4be2 to 77b6112 Compare May 20, 2021 17:37
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 20, 2021
@mauriciopoppe mauriciopoppe force-pushed the multidistro-windows-build branch from 77b6112 to e210f1b Compare June 2, 2021 18:57
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2021
@mauriciopoppe
Copy link
Member Author

/cc @jingxu97
/unhold

@k8s-ci-robot k8s-ci-robot requested a review from jingxu97 June 2, 2021 18:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2021
@jingxu97
Copy link
Contributor

jingxu97 commented Jun 2, 2021

/lgtm
/aprove

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@jingxu97
Copy link
Contributor

jingxu97 commented Jun 2, 2021

/approve

@mauriciopoppe
Copy link
Member Author

@msau42 do you know who can approve this change?

@msau42
Copy link
Collaborator

msau42 commented Jun 2, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97, mauriciopoppe, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@mauriciopoppe
Copy link
Member Author

@jingxu97 could you lgtm this one again please? I added some comments to the Dockerfile

@jingxu97
Copy link
Contributor

jingxu97 commented Jun 2, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit f2f7054 into kubernetes-csi:master Jun 2, 2021
This was referenced Aug 2, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@jingxu97 jingxu97

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mauriciopoppe @k8s-ci-robot @jingxu97 @msau42