feat: add support to prevent updates on objects #676
Conversation
This change adds a new actuation feature to the applier which allows objects to be created but not updated. This is useful in cases where the user wants to create the object if it does not exists, but then allow other clients to make updates to the object that are not reverted by the applier. The feature is used by providing the ignore mutation annotation on the declared object.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sdowell The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @mortent |
k8s-ci-robot
added
the
size/L
| return fmt.Sprintf("annotation prevents apply (%q: %q)", e.Annotation, e.Value) | ||
| } | ||
|
|
||
| func (e *AnnotationPreventedUpdateError) Is(err error) bool { |
There was a problem hiding this comment.
How will this function be used? I'm a bit confused as to why this is on the AnnotationPreventedUpdateError struct.
There was a problem hiding this comment.
This is following a similar pattern to the other Filter implementations, for example:
- PreventRemoveFilter: https://github.com/kubernetes-sigs/cli-utils/blob/master/pkg/apply/filter/prevent-remove-filter.go#L41
- DependencyFilter: https://github.com/kubernetes-sigs/cli-utils/blob/master/pkg/apply/filter/dependency-filter.go#L233
These errors are returned as events by the applier, so the caller of the applier can check the events and act on specific errors if desired. (That's my understanding of the primary use case)
3 participants
This change adds a new actuation feature to the applier which allows objects to be created but not updated. This is useful in cases where the user wants to create the object if it does not exists, but then allow other clients to make updates to the object that are not reverted by the applier.
The feature is used by providing the ignore mutation annotation on the declared object.