Add AWS cloud provider tags to pre-existing infrastructure

[pydctw]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Support writing AWS cloud provider tags on pre-existing infrastructure

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #2584

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

Support adding AWS cloud provider tags to pre-existing infrastructure
`kubernetes.io/cluster/<name> = shared` and `kubernetes.io/role/elb = 1` for public subnets
`kubernetes.io/cluster/<name> = shared` and`kubernetes.io/role/internal-elb = 1` for private subnets

[k8s-ci-robot]

Welcome @pydctw!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @pydctw. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[richardcase]

/ok-to-test

[Ankitasw]

@pydctw looks like the release note is not written in release note block, that's why bot added do-not-merge/release-note-label-needed. You can try to format it.

[pydctw]

@scottslowe, could you please review if it meets your requirements?

[randomvariable]

Do we need to make this opt-in? What if you haven't granted permissions to tag subnets, should we block cluster creation entirely?

[randomvariable]

Let's also make the release note more specific about what tag is being added.

[randomvariable]

/priority important-soon

[randomvariable]

/area networking

[scottslowe]

@pydctw I'm heading out of town on holiday, and wouldn't be much help in a code review anyway (still learning Golang). Happy to test a pre-release build in my test environment when I get back from holiday, if that would help.

[randomvariable]

@scottslowe that's fine scott. enjoy your holiday!

[pydctw]

Do we need to make this opt-in? What if you haven't granted permissions to tag subnets, should we block cluster creation entirely?

@randomvariable, I updated the PR as discussed. If tagging fails for unmanaged subnets, we record an event and proceed to cluster creation, hence preserving the current behavior. Added a test case named "Unmanaged VPC, 2 existing matching subnets, subnet tagging fails, should succeed" for the case.

[sedefsavas]

/lgtm

[richardcase]

Yeah seems good to me as well:

/lgtm

[randomvariable]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [randomvariable]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment