Skip to content

Fix AWSManagedControlPlane conversion #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2021
Merged

Fix AWSManagedControlPlane conversion #3037

merged 1 commit into from
Dec 15, 2021

Conversation

jonathanbeber
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
The AWSManagedControlPlane object conversion from v1alpha3 to
v1beta1 were not considering new fields in status and spec. The bug
is covered by tests, but these are failing silently at the moment as
described in #3032.

Which issue(s) this PR fixes

Special notes for your reviewer:

Checklist:

  • squashed commits

Release note:

Bugfix in  `AWSManagedControlPlane` object conversion from v1alpha3 to v1beta1. Some fields in Status and Spec were not being considered during conversion

@jonathanbeber
Fix AWSManagedControlPlane conversion
352731d 
The `AWSManagedControlPlane` object conversion from `v1alpha3` to
`v1beta1` were not considering new fields in status and spec. The bug
is covered by tests, but these are failing silently at the moment as
described in kubernetes-sigs#3032.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. needs-priority labels Dec 15, 2021
@k8s-ci-robot
Copy link
Contributor

@jonathanbeber: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 15, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jonathanbeber. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 15, 2021
@sedefsavas
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 15, 2021
@jonathanbeber jonathanbeber mentioned this pull request Dec 15, 2021
Merged
1 task
@sedefsavas
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit c474bf0 into kubernetes-sigs:main Dec 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Dec 15, 2021
@jonathanbeber jonathanbeber deleted the eks_conversion_fix branch December 15, 2021 20:47
richardchen-db pushed a commit to databricks/cluster-api-provider-aws-1 that referenced this pull request Jan 14, 2023
@k8s-ci-robot
Merge pull request kubernetes-sigs#3037 from jonathanbeber/eks_conver…
0000757 
…sion_fix

Fix AWSManagedControlPlane conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@dthorsen dthorsen Awaiting requested review from dthorsen

Assignees

@sedefsavas sedefsavas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathanbeber @k8s-ci-robot @sedefsavas