🐛 Wait for volume detach after node drain

[jzhoucliqr]

What this PR does / why we need it:

Pod deletion and volume detach happen asynchronously, so pod could be deleted before volume detached from the node
When deleting a machine, this could cause issues for some storage provisioner, for example, vsphere-volume this is problematic because if the node deleted before volume detaching success, then the underline VMDK will be deleted together with the Machine

This PR added a fix to wait for volume detach from the node after node draining.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4707

[k8s-ci-robot]

Hi @jzhoucliqr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MaxRink]

/ok-to-test

[jzhoucliqr]

/test pull-cluster-api-test-main

[jzhoucliqr]

/test pull-cluster-api-test-main

[vincepri]

How do we give some sort of timeout? What if a Volume never gets detached?

Adding this in without a timeout can be considered a behavioral change on deletion, although I do agree that's probably more correct to wait for all volumes to be fully detached I'd like to make sure we have enough agreement on this change.

cc @CecileRobertMichon @randomvariable @yastij

[MaxRink]

@vincepri shouldn't nodeDrainTimeoutstill apply?
So i would view it as the same as unfullfillable PDBs: If you don't specified that you might end up with things pending until manual intervention.

[vincepri]

That's true, I just saw that this code is in the isNodeDrainAllowed block, all good 👍

[jzhoucliqr]

/test pull-cluster-api-test-main

[vincepri]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment