Envtest is not idempotent when installing CRDs, an issue when UseExistingCluster=true

[teddyking]

We want to use envtest against an existing cluster and are having issues when installing CRDs. Envtest will fail on the second running of the tests because the CRDs already exist in the cluster. This is only an issue when using an existing cluster because normally envtest starts a new control plane each time.

Example setup we want to use:

		testEnv = &envtest.Environment{
			CRDDirectoryPaths:  []string{filepath.Join("..", "config", "crds")},
			UseExistingCluster: true,
		}

And error we get:

Expected error:
      <*errors.StatusError | 0xc00012a2d0>: {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {SelfLink: "", ResourceVersion: "", Continue: ""},
              Status: "Failure",
              Message: "customresourcedefinitions.apiextensions.k8s.io \"mycrd.meep.io\" already exists",
              Reason: "AlreadyExists",
              Details: {
                  Name: "mycrd.meep.io",
                  Group: "apiextensions.k8s.io",
                  Kind: "customresourcedefinitions",
                  UID: "",
                  Causes: nil,
                  RetryAfterSeconds: 0,
              },
              Code: 409,
          },
      }
      customresourcedefinitions.apiextensions.k8s.io "mycrd.meep.io" already exists
  not to have occurred

Is it possible to have envtest reinstall CRDs on every run rather than fail?

Thanks
Ed & @Samze & @ablease

[DirectXMan12]

Probably, it should clean up the CRDs at the end, but replacing is also an option. Would you be willing to submit a PR for it?

[DirectXMan12]

/kind feature
/priority important-longterm

[teddyking]

Great! Yeah we'd be happy to PR this in, we'll try to get something opened in the next few days.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[DirectXMan12]

/remove-lifecycle stale

[DirectXMan12]

will be fixed by #453

[DirectXMan12]

or by #457

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten