Skip to content

👻 [tmp] break some lints #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DirectXMan12
Copy link
Contributor

Oh, the humanity!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from droot and pwittrock June 7, 2019 00:19
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2019
@DirectXMan12
Copy link
Contributor Author

/hold

Please don't merge this

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2019
@DirectXMan12 DirectXMan12 changed the title [tmp] break some lints 👻 [tmp] break some lints Jun 7, 2019
@DirectXMan12 DirectXMan12 force-pushed the tmp/break-some-lints branch from b3cd8b7 to f2ab652 Compare June 7, 2019 00:23
@DirectXMan12
Copy link
Contributor Author

darn, looks like checks triggered by push seem to run in the context of the forked repo, which means the forked repo has to have actions enabled (which'll be awesome after the closed beta, but makes me sad in the mean time).

@DirectXMan12 DirectXMan12 deleted the tmp/break-some-lints branch June 7, 2019 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants