Project setup script authorizes GCE to use Cloud KMS keys on the dev project.

[jeremyje]

…project.

What type of PR is this?
/kind feature

What this PR does / why we need it:
The project setup script will now run gcloud projects add-iam-policy-binding "${PROJECT}" --member serviceAccount:"service-${PROJECT_NUMBER}@compute-system.iam.gserviceaccount.com" --role "roles/cloudkms.cryptoKeyEncrypterDecrypter".

This is important because it authorizes GCE to use Cloud KMS encryption keys. Without this grant usage to Cloud KMS will be blocked and tests will fail with,

Should create CMEK key, go through volume lifecycle, validate behavior on key revoke and restore [It]
  /usr/local/google/home/jeremyedwards/github/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/test/e2e/tests/single_zone_e2e_test.go:347

  CreateVolume failed with error: rpc error: code = Internal desc = CreateVolume failed to create single zonal disk "gcepd-csi-e2e-abfae45e-d0af-4cd7-a996-8b5e74089a2e": failed to insert zonal disk: unknown Insert disk error: googleapi: Error 400: Cloud KMS error when using key projects/REDACTED/locations/global/keyRings/gce-pd-csi-test-ring/cryptoKeys/test-key-99db27e5-88e7-47c5-a1f8-4b7e4cebce88: Permission 'cloudkms.cryptoKeyVersions.useToEncrypt' denied on resource 'projects/REDACTED/locations/global/keyRings/gce-pd-csi-test-ring/cryptoKeys/test-key-99db27e5-88e7-47c5-a1f8-4b7e4cebce88' (or it may not exist)., kmsPermissionDenied
  Expected
      <*status.statusError | 0xc0000bb040>: {
          Code: 13,
          Message: "CreateVolume failed to create single zonal disk \"gcepd-csi-e2e-abfae45e-d0af-4cd7-a996-8b5e74089a2e\": failed to insert zonal disk: unknown Insert disk error: googleapi: Error 400: Cloud KMS error when using key projects/REDACTED/locations/global/keyRings/gce-pd-csi-test-ring/cryptoKeys/test-key-99db27e5-88e7-47c5-a1f8-4b7e4cebce88: Permission 'cloudkms.cryptoKeyVersions.useToEncrypt' denied on resource 'projects/REDACTED/locations/global/keyRings/gce-pd-csi-test-ring/cryptoKeys/test-key-99db27e5-88e7-47c5-a1f8-4b7e4cebce88' (or it may not exist)., kmsPermissionDenied",
          Details: nil,
          XXX_NoUnkeyedLiteral: {},
          XXX_unrecognized: nil,
          XXX_sizecache: 0,
      }
  to be nil

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Hi @jeremyje. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mattcary]

/assign mattcary
/ok-to-test

[mattcary]

/lgtm

[jingxu97]

this script is for user to set up their cluster, if they do not use cmek feature, this part is not needed.
Is it better to give an option? If user enable this option, then set it up?

[mattcary]

That's not a bad point. My thought was that it's better to have this stuff on by default as, eg for testing it makes everything more consistent.

But maybe we don't want to add policy bindings by default.

[jeremyje]

Added a parameter called ENABLE_KMS.

[mattcary]

/lgtm

I think it's good to have to explicitly specify KMS, that's better than having a default that won't be noticed until it's too late.

[jeremyje]

Is there anything remaining in order to get approval?

[mattcary]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyje, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mattcary]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment