Move Dockerfile next to CSI main, remove $BASE_IMAGE arg.

[jeremyje]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Moves the Dockerfile from the root of the repository next to the binary. This better aligns with expectations of csi-release-tools and also allows for additional containers to be added in the future.

This PR also removes the $BASE_IMAGE variable from the Dockerfile.windows because it's always set to servercore. The base OS flavor is typically determined by the binary's dependencies so there's very little value to parameterize this field. This reduces the burden of implementing, kubernetes-csi/csi-release-tools#100.

Which issue(s) this PR fixes:
Partial fix for #585

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Hi @jeremyje. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mattcary]

/assign
/ok-to-test

[mattcary]

/lgtm

[msau42]

We'll need to update our Louhi pipeline to use this new Dockerfile location too

[msau42]

/assign @jingxu97
to review windows changes.

[msau42]

/hold

We're in the middle of releasing 1.0. I think we should wait on this until we're done to minimize disruption to our release pipeline

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jeremyje
To complete the pull request process, please assign jingxu97
You can assign the PR to them by writing /assign @jingxu97 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mattcary]

We'll need to update our Louhi pipeline to use this new Dockerfile location too

Oh, good catch. It would be nice to have the louhi pipeline work off of the makefile rather than running docker directly. It looks like that's possible but we should make that change first (after the 1.0 release of course...)

[k8s-ci-robot]

@jeremyje: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten